From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Carlos López" <clopez@suse.de>,
linux-trace-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"James Clark" <james.clark@linaro.org>,
"open list:UPROBES" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] uprobes: replace deprecated kmap_atomic() with kmap_local_page()
Date: Thu, 5 Feb 2026 13:29:30 +0100 [thread overview]
Message-ID: <aYSNKqr2rmO7dHBm@redhat.com> (raw)
In-Reply-To: <20260205111208.GK232055@noisy.programming.kicks-ass.net>
On 02/05, Peter Zijlstra wrote:
>
> On Thu, Feb 05, 2026 at 11:57:25AM +0100, Carlos López wrote:
> > kmap_atomic() has been deprecated for a few years, and kmap_local_page()
> > should be used instead, so replace it. Since the uprobes code relied on
> > kmap_atomic() disabling page faults to access user pages, add the
> > required calls to keep the existing behavior.
>
> Are those pagefault_disable()s really needed here, or is this just
> cargo-culting?
No, I think there are not needed.
And the (already in tip) patches from Keke do not add pagefault_disable().
is_trap_at_addr() does pagefault_disable() because it is called with
mm->mmap_lock held.
Oleg.
next prev parent reply other threads:[~2026-02-05 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 10:57 [PATCH] uprobes: replace deprecated kmap_atomic() with kmap_local_page() Carlos López
2026-02-05 11:12 ` Peter Zijlstra
2026-02-05 11:19 ` Carlos López
2026-02-05 12:29 ` Oleg Nesterov [this message]
2026-02-05 11:25 ` Oleg Nesterov
2026-02-05 11:27 ` Carlos López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYSNKqr2rmO7dHBm@redhat.com \
--to=oleg@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=clopez@suse.de \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.