From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosry.ahmed@linux.dev>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/26] Nested SVM fixes, cleanups, and hardening
Date: Thu, 5 Feb 2026 17:38:44 -0800 [thread overview]
Message-ID: <aYVGJJuRdYTzO20p@google.com> (raw)
In-Reply-To: <20260115011312.3675857-1-yosry.ahmed@linux.dev>
On Thu, Jan 15, 2026, Yosry Ahmed wrote:
> Yosry Ahmed (26):
> KVM: SVM: Switch svm_copy_lbrs() to a macro
> KVM: SVM: Add missing save/restore handling of LBR MSRs
> KVM: selftests: Add a test for LBR save/restore (ft. nested)
> KVM: nSVM: Always inject a #GP if mapping VMCB12 fails on nested VMRUN
> KVM: nSVM: Triple fault if mapping VMCB12 fails on nested #VMEXIT
> KVM: nSVM: Triple fault if restore host CR3 fails on nested #VMEXIT
> KVM: nSVM: Drop nested_vmcb_check_{save/control}() wrappers
> KVM: nSVM: Call enter_guest_mode() before switching to VMCB02
> KVM: nSVM: Make nested_svm_merge_msrpm() return an errno
> KVM: nSVM: Call nested_svm_merge_msrpm() from enter_svm_guest_mode()
> KVM: nSVM: Call nested_svm_init_mmu_context() before switching to
> VMCB02
> KVM: nSVM: Refactor minimal #VMEXIT handling out of
> nested_svm_vmexit()
> KVM: nSVM: Unify handling of VMRUN failures with proper cleanup
> KVM: nSVM: Clear EVENTINJ field in VMCB12 on nested #VMEXIT
> KVM: nSVM: Drop the non-architectural consistency check for NP_ENABLE
> KVM: nSVM: Add missing consistency check for nCR3 validity
> KVM: nSVM: Add missing consistency check for hCR0.PG and NP_ENABLE
> KVM: nSVM: Add missing consistency check for EFER, CR0, CR4, and CS
> KVM: nSVM: Add missing consistency check for event_inj
> KVM: SVM: Rename vmcb->nested_ctl to vmcb->misc_ctl
> KVM: SVM: Rename vmcb->virt_ext to vmcb->misc_ctl2
> KVM: SVM: Use BIT() and GENMASK() for definitions in svm.h
> KVM: nSVM: Cache all used fields from VMCB12
> KVM: nSVM: Restrict mapping VMCB12 on nested VMRUN
> KVM: nSVM: Sanitize control fields copied from VMCB12
> KVM: nSVM: Only copy NP_ENABLE from VMCB01's misc_ctl
All in all, looks good. A few comments, but I don't anticipate a big jump in
the patch count :-)
Note, make sure to rebase on the latest kvm-x86 next, there are a handful of
minor conflicts.
prev parent reply other threads:[~2026-02-06 1:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 1:12 [PATCH v4 00/26] Nested SVM fixes, cleanups, and hardening Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 01/26] KVM: SVM: Switch svm_copy_lbrs() to a macro Yosry Ahmed
2026-02-06 0:59 ` Sean Christopherson
2026-02-06 1:12 ` Yosry Ahmed
2026-02-06 1:25 ` Sean Christopherson
2026-02-06 15:13 ` Yosry Ahmed
2026-02-06 15:54 ` Sean Christopherson
2026-01-15 1:12 ` [PATCH v4 02/26] KVM: SVM: Add missing save/restore handling of LBR MSRs Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 03/26] KVM: selftests: Add a test for LBR save/restore (ft. nested) Yosry Ahmed
2026-02-06 1:03 ` Sean Christopherson
2026-01-15 1:12 ` [PATCH v4 04/26] KVM: nSVM: Always inject a #GP if mapping VMCB12 fails on nested VMRUN Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 05/26] KVM: nSVM: Triple fault if mapping VMCB12 fails on nested #VMEXIT Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 06/26] KVM: nSVM: Triple fault if restore host CR3 " Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 07/26] KVM: nSVM: Drop nested_vmcb_check_{save/control}() wrappers Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 08/26] KVM: nSVM: Call enter_guest_mode() before switching to VMCB02 Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 09/26] KVM: nSVM: Make nested_svm_merge_msrpm() return an errno Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 10/26] KVM: nSVM: Call nested_svm_merge_msrpm() from enter_svm_guest_mode() Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 11/26] KVM: nSVM: Call nested_svm_init_mmu_context() before switching to VMCB02 Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 12/26] KVM: nSVM: Refactor minimal #VMEXIT handling out of nested_svm_vmexit() Yosry Ahmed
2026-01-15 1:12 ` [PATCH v4 13/26] KVM: nSVM: Unify handling of VMRUN failures with proper cleanup Yosry Ahmed
2026-02-06 0:47 ` Sean Christopherson
2026-02-06 15:40 ` Yosry Ahmed
2026-02-06 1:20 ` Sean Christopherson
2026-01-15 1:13 ` [PATCH v4 14/26] KVM: nSVM: Clear EVENTINJ field in VMCB12 on nested #VMEXIT Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 15/26] KVM: nSVM: Drop the non-architectural consistency check for NP_ENABLE Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 16/26] KVM: nSVM: Add missing consistency check for nCR3 validity Yosry Ahmed
2026-01-22 1:38 ` Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 17/26] KVM: nSVM: Add missing consistency check for hCR0.PG and NP_ENABLE Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 18/26] KVM: nSVM: Add missing consistency check for EFER, CR0, CR4, and CS Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 19/26] KVM: nSVM: Add missing consistency check for event_inj Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 20/26] KVM: SVM: Rename vmcb->nested_ctl to vmcb->misc_ctl Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 21/26] KVM: SVM: Rename vmcb->virt_ext to vmcb->misc_ctl2 Yosry Ahmed
2026-02-06 1:31 ` Sean Christopherson
2026-02-06 16:04 ` Yosry Ahmed
2026-02-06 17:58 ` Sean Christopherson
2026-01-15 1:13 ` [PATCH v4 22/26] KVM: SVM: Use BIT() and GENMASK() for definitions in svm.h Yosry Ahmed
2026-02-06 1:37 ` Sean Christopherson
2026-02-06 15:45 ` Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 23/26] KVM: nSVM: Cache all used fields from VMCB12 Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 24/26] KVM: nSVM: Restrict mapping VMCB12 on nested VMRUN Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 25/26] KVM: nSVM: Sanitize control fields copied from VMCB12 Yosry Ahmed
2026-01-15 1:13 ` [PATCH v4 26/26] KVM: nSVM: Only copy NP_ENABLE from VMCB01's misc_ctl Yosry Ahmed
2026-02-06 1:38 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYVGJJuRdYTzO20p@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.