All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Helge Deller <deller@gmx.de>
Cc: Chen Ni <nichen@iscas.ac.cn>,
	linux-fbdev@vger.kernel.org,  dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 1/3] fbdev: au1100fb: Mark several local functions as static
Date: Fri, 6 Feb 2026 15:15:25 +0100	[thread overview]
Message-ID: <aYX3KYbdSUPTSHG-@monoceros> (raw)
In-Reply-To: <28affc45-7f41-40a5-82bf-308a6e34d956@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

Hello Helge,

On Fri, Feb 06, 2026 at 12:22:39PM +0100, Helge Deller wrote:
> On 2/6/26 12:06, Helge Deller wrote:
> > On 2/4/26 10:15, Uwe Kleine-König wrote:
> > > This fixes several (fatal) compiler warnings à la
> > > 
> > >     drivers/video/fbdev/au1100fb.c:530:6: error: no previous prototype for ‘au1100fb_drv_remove’ [-Werror=missing-prototypes]
> > >       523 | void au1100fb_drv_remove(struct platform_device *dev)
> > >           |      ^~~~~~~~~~~~~~~~~~~
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > 
> > I've applied patches #1 and #3 of this series to the fbdev git tree.
> > 
> > Patch #2 needs fixing, as it breaks build on s390x.
> 
> I fixed up patch #2 manually for now by excluding s390x as test platform.
> If you have a better patch, I'm happy to take it.

I didn't look at that yet, but I suspect that the failure isn't s390x
specific and I think it's better to not relax the dependencies yet.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-02-06 14:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  9:15 [PATCH v1 0/3] fbdev: au1100fb: support COMPILE_TEST and fix multi-device support Uwe Kleine-König
2026-02-04  9:15 ` [PATCH v1 1/3] fbdev: au1100fb: Mark several local functions as static Uwe Kleine-König
2026-02-06 11:06   ` Helge Deller
2026-02-06 11:22     ` Helge Deller
2026-02-06 14:15       ` Uwe Kleine-König [this message]
2026-02-04  9:15 ` [PATCH v1 2/3] fbdev: au1100fb: Make driver compilable on non-mips platforms Uwe Kleine-König
2026-02-04 14:13   ` kernel test robot
2026-02-04 14:34   ` kernel test robot
2026-02-04 15:16   ` kernel test robot
2026-02-04  9:15 ` [PATCH v1 3/3] fbdev: au1100fb: Don't store device specific data in global variables Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYX3KYbdSUPTSHG-@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.