From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/overlay: remove dead code with MTL platform checks
Date: Fri, 6 Feb 2026 15:24:57 +0200 [thread overview]
Message-ID: <aYXrqU7f-SJvmH4X@intel.com> (raw)
In-Reply-To: <20260206125949.243643-1-jani.nikula@intel.com>
On Fri, Feb 06, 2026 at 02:59:49PM +0200, Jani Nikula wrote:
> Commit c5741c5c1122 ("drm/i915/display: Do not use stolen on MTL") added
> some checks for MTL in overlay code. However, this is never run on
> MTL. Clean it up.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_overlay.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
> index 88eb7ae5765c..ae2a3527645f 100644
> --- a/drivers/gpu/drm/i915/display/intel_overlay.c
> +++ b/drivers/gpu/drm/i915/display/intel_overlay.c
> @@ -1358,12 +1358,11 @@ static int get_registers(struct intel_overlay *overlay, bool use_phys)
> {
> struct intel_display *display = overlay->display;
> struct drm_i915_private *i915 = to_i915(display->drm);
> - struct drm_i915_gem_object *obj = ERR_PTR(-ENODEV);
> + struct drm_i915_gem_object *obj;
> struct i915_vma *vma;
> int err;
>
> - if (!display->platform.meteorlake) /* Wa_22018444074 */
> - obj = i915_gem_object_create_stolen(i915, PAGE_SIZE);
> + obj = i915_gem_object_create_stolen(i915, PAGE_SIZE);
> if (IS_ERR(obj))
> obj = i915_gem_object_create_internal(i915, PAGE_SIZE);
> if (IS_ERR(obj))
> --
> 2.47.3
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-02-06 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 12:59 [PATCH] drm/i915/overlay: remove dead code with MTL platform checks Jani Nikula
2026-02-06 13:24 ` Ville Syrjälä [this message]
2026-02-10 12:44 ` Jani Nikula
2026-02-06 14:07 ` ✗ i915.CI.BAT: failure for " Patchwork
2026-02-09 16:49 ` ✓ i915.CI.BAT: success for drm/i915/overlay: remove dead code with MTL platform checks (rev2) Patchwork
2026-02-10 0:26 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYXrqU7f-SJvmH4X@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.