All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@arm.com>
Cc: Ian Rogers <irogers@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf tests: build-test coverage for NO_JEVENTS=1
Date: Fri, 6 Feb 2026 11:59:25 -0300	[thread overview]
Message-ID: <aYYBzYULHaHzMW4n@x1> (raw)
In-Reply-To: <20260206085349.GD3529712@e132581.arm.com>

On Fri, Feb 06, 2026 at 08:53:49AM +0000, Leo Yan wrote:
> On Thu, Feb 05, 2026 at 10:36:02AM -0800, Ian Rogers wrote:
> > Leo reported the NO_JEVENTS=1 build being broken and this highlighted
> > it being missing from the build-test, add it.
> 
> To be clear, I did not say the build is broken.
> 
> The issue I reported is that `perf stat` is broken, both with
> NO_JEVENTS=1 enabled and without that configuration.
> 
> With updating the commit log, this patch LGTM:

I did it and will apply the Reviewed-by to patch 2/2 too, ok?

- Arnaldo
 
> Reviewed-by: Leo Yan <leo.yan@arm.com>
> 
> > Reported-by: Leo Yan <leo.yan@arm.com>
> > Closes: https://lore.kernel.org/linux-perf-users/20260205175250.GC3529712@e132581.arm.com/
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/tests/make | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> > index eb41516c0562..6587dc326d1b 100644
> > --- a/tools/perf/tests/make
> > +++ b/tools/perf/tests/make
> > @@ -70,6 +70,7 @@ make_python_perf_so := $(python_perf_so)
> >  make_debug          := DEBUG=1
> >  make_nondistro      := BUILD_NONDISTRO=1
> >  make_extra_tests    := EXTRA_TESTS=1
> > +make_no_jevents     := NO_JEVENTS=1
> >  make_jevents_all    := JEVENTS_ARCH=all
> >  make_no_bpf_skel    := BUILD_BPF_SKEL=0
> >  make_gen_vmlinux_h  := GEN_VMLINUX_H=1
> > @@ -144,6 +145,7 @@ ifneq ($(new_libbfd),)
> >  run += make_nondistro
> >  endif
> >  run += make_extra_tests
> > +run += make_no_jevents
> >  run += make_jevents_all
> >  run += make_no_bpf_skel
> >  run += make_gen_vmlinux_h
> > -- 
> > 2.53.0.rc2.204.g2597b5adb4-goog
> > 

  parent reply	other threads:[~2026-02-06 14:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05 18:36 [PATCH v1 1/2] perf tests: build-test coverage for NO_JEVENTS=1 Ian Rogers
2026-02-05 18:36 ` [PATCH v1 2/2] perf metricgroup: Don't early exit if no CPUID table exists Ian Rogers
2026-02-06 10:45   ` Leo Yan
2026-02-06 12:33     ` Leo Yan
2026-02-06 18:57       ` Ian Rogers
2026-02-06 21:50         ` Leo Yan
2026-02-06 22:16           ` Ian Rogers
2026-02-07  0:14             ` Ian Rogers
2026-02-07  0:49               ` [PATCH v1] perf metricgroup: Fix metricgroup__has_metric_or_groups Ian Rogers
2026-02-09  9:22                 ` Leo Yan
2026-02-09 23:06                   ` Ian Rogers
2026-02-10  9:11                     ` Leo Yan
2026-02-24 17:57                 ` Namhyung Kim
2026-02-06  8:53 ` [PATCH v1 1/2] perf tests: build-test coverage for NO_JEVENTS=1 Leo Yan
2026-02-06 14:57   ` Arnaldo Carvalho de Melo
2026-02-06 14:59   ` Arnaldo Carvalho de Melo [this message]
2026-02-06 16:09     ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYYBzYULHaHzMW4n@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.