All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <corey@minyard.net>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Igor Raits <igor@gooddata.com>,
	Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
	linux-acpi@vger.kernel.org, linux-hwmon@vger.kernel.org,
	Daniel Secik <daniel.secik@gooddata.com>,
	Zdenek Pesek <zdenek.pesek@gooddata.com>,
	Jiri Jurica <jiri.jurica@gooddata.com>,
	Huisong Li <lihuisong@huawei.com>
Subject: Re: [BISECTED - impi related]: acpi_power_meter: power*_average sysfs read hangs, mutex deadlock in hwmon_attr_show since v6.18.y
Date: Fri, 6 Feb 2026 10:08:45 -0600	[thread overview]
Message-ID: <aYYSDWaeiCnkwqAF@mail.minyard.net> (raw)
In-Reply-To: <CAJZ5v0i_BmeGROzQFpUCyF5MkA7sFkP3y8jjqH0mD2r2Wqj_xA@mail.gmail.com>

On Fri, Feb 06, 2026 at 01:08:56PM +0100, Rafael J. Wysocki wrote:
> On Thu, Feb 5, 2026 at 11:34 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >

snip..

> 
> > 2. Excessive Polling (Timer Overwrite):
> > In `smi_timeout()`, the timer is unconditionally reset to a short timeout (e.g., 10ms) at the end of the function, unless the state machine is IDLE. When the state machine returns `SI_SM_HOSED`, `smi_event_handler()` correctly sets the timer to a long backoff (1 second). However, `smi_timeout()` subsequently overwrites this with the short timeout. This causes the driver to poll the hosed BMC every 10ms instead of backing off for 1 second, resulting in unnecessary CPU overhead.
> 
> Well, that's not nice, but it doesn't seem to be related to the
> observed symptoms.

I have a fix for this, too.  Thanks for the report.

snip..

-corey

  parent reply	other threads:[~2026-02-06 16:08 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 18:21 acpi_power_meter: power*_average sysfs read hangs, mutex deadlock in hwmon_attr_show since v6.18.y Jaroslav Pulchart
2026-01-22 18:55 ` Rafael J. Wysocki
2026-01-22 19:51   ` Guenter Roeck
2026-01-22 20:42     ` Rafael J. Wysocki
2026-01-22 22:28       ` Guenter Roeck
2026-01-23 10:19         ` Jaroslav Pulchart
2026-01-23 18:23           ` Guenter Roeck
2026-01-27 11:58             ` Jaroslav Pulchart
2026-01-27 14:24               ` Guenter Roeck
2026-01-29 15:26                 ` Jaroslav Pulchart
2026-01-29 18:22                   ` Guenter Roeck
2026-02-02 16:48                     ` Jaroslav Pulchart
2026-02-02 18:00                       ` Guenter Roeck
2026-02-02 18:14                         ` Jaroslav Pulchart
2026-02-02 19:26                           ` Rafael J. Wysocki
2026-02-03  0:26                             ` Guenter Roeck
2026-02-03  8:23                             ` Jaroslav Pulchart
2026-02-03 23:21                               ` [BISECTED]: " Jaroslav Pulchart
2026-02-04  1:01                                 ` Guenter Roeck
2026-02-04  8:20                                   ` Jaroslav Pulchart
2026-02-04 19:54                                   ` Igor Raits
2026-02-04 22:48                                     ` Guenter Roeck
2026-02-05  7:25                                       ` Igor Raits
2026-02-05 17:51                                         ` Guenter Roeck
2026-02-05 19:04                                           ` Rafael J. Wysocki
2026-02-05 20:57                                             ` [BISECTED - impi related]: " Guenter Roeck
2026-02-06 12:08                                               ` Rafael J. Wysocki
2026-02-06 15:58                                                 ` Corey Minyard
2026-02-06 19:33                                                   ` Rafael J. Wysocki
2026-02-10 16:31                                                   ` Rafael J. Wysocki
2026-02-12  9:10                                                     ` Jaroslav Pulchart
2026-02-12 12:27                                                       ` Rafael J. Wysocki
2026-02-12 16:48                                                         ` Corey Minyard
2026-02-12 17:22                                                           ` Rafael J. Wysocki
2026-02-12 18:34                                                             ` Corey Minyard
2026-02-12 21:33                                                               ` Rafael J. Wysocki
2026-02-12 22:06                                                                 ` Corey Minyard
2026-02-13  6:55                                                                 ` Corey Minyard
2026-02-13 12:47                                                                   ` Rafael J. Wysocki
2026-02-06 16:08                                                 ` Corey Minyard [this message]
2026-02-06 16:31                                                   ` Guenter Roeck
2026-02-06 19:35                                                     ` Rafael J. Wysocki
2026-01-23  2:53       ` lihuisong (C)
2026-01-27 16:13         ` Guenter Roeck
2026-01-28 18:18   ` Guenter Roeck
2026-01-28 18:45     ` Rafael J. Wysocki
2026-01-28 19:52       ` Rafael J. Wysocki
2026-01-28 21:52         ` Guenter Roeck
2026-01-29 14:18           ` [PATCH v1] hwmon: (acpi_power_meter) Fix deadlocks related to acpi_power_meter_notify() Rafael J. Wysocki
2026-01-30  1:07             ` Guenter Roeck
2026-01-30 17:51               ` Rafael J. Wysocki
2026-01-30 18:51                 ` Guenter Roeck
2026-01-30  1:47             ` lihuisong (C)
2026-01-30  5:07               ` Guenter Roeck
2026-01-30  8:40                 ` lihuisong (C)
2026-01-30 17:53                   ` Rafael J. Wysocki
2026-01-31 10:06                     ` lihuisong (C)
2026-01-31 15:29             ` Guenter Roeck
2026-02-01 11:40               ` Rafael J. Wysocki
2026-01-29  1:55     ` acpi_power_meter: power*_average sysfs read hangs, mutex deadlock in hwmon_attr_show since v6.18.y lihuisong (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYYSDWaeiCnkwqAF@mail.minyard.net \
    --to=corey@minyard.net \
    --cc=daniel.secik@gooddata.com \
    --cc=igor@gooddata.com \
    --cc=jaroslav.pulchart@gooddata.com \
    --cc=jiri.jurica@gooddata.com \
    --cc=lihuisong@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rafael@kernel.org \
    --cc=zdenek.pesek@gooddata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.