Re: [PATCH v2 8/9] migration/options: Stop freeing s->parameters members individually

[Peter Xu <peterx@redhat.com>]

On Fri, Feb 06, 2026 at 09:29:04AM -0300, Fabiano Rosas wrote:
> There's some amount of rigidness caused by qdev requirements
> unfortunately.
> 
> I'm not sure if I ever posted it, but I wrote some code to move the
> parameters into a MigrationOptions object so we could make
> MigrationState not be a TYPE_DEVICE anymore. But then we'd end up with
> something like -global migration-options by default, so it kinda killed
> the idea.

It's not strictly about TYPE_DEVICE, but reusing of qdev properties, right?
At least the issue described by your comment was about offseting and it
sounds like so.

I just want to double check with you that I think the problem you described
will also present even after applying my other series:

https://lore.kernel.org/r/20251209162857.857593-1-peterx@redhat.com

That series only removes the TYPE_DEVICE dependency, but not qdev
properties.  I think it's the qdev property trick that is relevant at least
to the offset issue you mentioned so MigrationParameters cannot be
g_new()ed.

The major use case for this qdev reuse is: (1) help scripting, so as to use
-global migration.XXX=YYY, (2) support migration in machine compat
properties.  IIUC (1) isn't a major thing we ask for (again, maybe I used
the most of it.. but maybe only me; I'm not sure..), as long as anything
can keep (2) working then we can consider.

-- 
Peter Xu