From: Harry Yoo <harry.yoo@oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Alexei Starovoitov <ast@kernel.org>, Hao Li <hao.li@linux.dev>,
linux-mm@kvack.org
Subject: Re: [PATCH 0/2] mm/slab: fix lockdep warnings with kmalloc_nolock()
Date: Sat, 7 Feb 2026 02:37:56 +0900 [thread overview]
Message-ID: <aYYm9ICnlB_yu7PS@hyeyoo> (raw)
In-Reply-To: <20260206171348.35886-1-harry.yoo@oracle.com>
On Sat, Feb 07, 2026 at 02:13:46AM +0900, Harry Yoo wrote:
> Hi, I've observed a tw lockdep warnings while testing
> kmalloc_nolock() in NMI:
>
> 1. Accessing current->mems_allowed_seq seqlock in NMI isn't safe
> and lockdep complains.
>
> 2. w/ CONFIG_SLAB_FREELIST_RANDOM, get_random_u32() acquires
> a local_lock, which isn't safe in NMI and could cause a deadlock.
>
> Let's fix them.
I think we should probably add some sort of
kmalloc_nolock()/kfree_nolock() test cases in lib/tests/slub_kunit.c.
These haven't been discovered by bots because (I guess) it is very
unlikely for bots to somehow trigger those APIs in NMI.
Also, I forgot to mention that this is based on slab/for-next:
commit bc33906024eb5955294e28128c3d0f492d2ded5e
Merge: ec15c383fcda 40fd0acc45d0
Author: Vlastimil Babka <vbabka@suse.cz>
Date: Thu Jan 29 10:10:50 2026 +0100
Merge branch 'slab/for-7.0/sheaves' into slab/for-next
> Harry Yoo (2):
> mm/slab: skip get_from_any_partial() if !allow_spin
> mm/slab: use prandom if !allow_spin
>
> mm/slub.c | 36 ++++++++++++++++++++++++++++++++----
> 1 file changed, 32 insertions(+), 4 deletions(-)
>
> --
> 2.43.0
>
--
Cheers,
Harry / Hyeonggon
next prev parent reply other threads:[~2026-02-06 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 17:13 [PATCH 0/2] mm/slab: fix lockdep warnings with kmalloc_nolock() Harry Yoo
2026-02-06 17:13 ` [PATCH 1/2] mm/slab: skip get_from_any_partial() if !allow_spin Harry Yoo
2026-02-06 18:10 ` Vlastimil Babka
2026-02-06 19:19 ` Alexei Starovoitov
2026-02-09 3:18 ` Harry Yoo
2026-02-09 19:03 ` Vlastimil Babka
2026-02-06 17:13 ` [PATCH 2/2] mm/slab: use prandom " Harry Yoo
2026-02-06 18:27 ` Vlastimil Babka
2026-02-06 19:22 ` Alexei Starovoitov
2026-02-07 1:25 ` Harry Yoo
2026-02-06 17:37 ` Harry Yoo [this message]
2026-02-09 19:03 ` [PATCH 0/2] mm/slab: fix lockdep warnings with kmalloc_nolock() Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYYm9ICnlB_yu7PS@hyeyoo \
--to=harry.yoo@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=cl@gentwo.org \
--cc=hao.li@linux.dev \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.