From: Dan Carpenter <dan.carpenter@linaro.org>
To: Yoelvis Oliveros <yoelvisoliveros@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: octeon: type change from uint<bits>_t to u<bits>
Date: Tue, 10 Feb 2026 09:50:37 +0300 [thread overview]
Message-ID: <aYrVPUj1nma3DUPo@stanley.mountain> (raw)
In-Reply-To: <aYq028TNyXQWZ_v5@home-pc>
On Tue, Feb 10, 2026 at 12:36:31AM -0400, Yoelvis Oliveros wrote:
> Runing the ckeckpatch.pl on the staging/octeon driver they where using
> uint<8/16/32/64>_T as type declaration and the checkpatch.pl was
> putting a [CHECK] flag on those and that they should be change to
> u<8/16/32/64>
>
> Signed-off-by: Yoelvis Oliveros <yoelvisoliveros@gmail.com>
> ---
> drivers/staging/octeon/octeon-stubs.h | 1922 +++++++++++++------------
> 1 file changed, 972 insertions(+), 950 deletions(-)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 35b5078ba51e..aea3dad37cfe 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1,188 +1,190 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> -#define CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE 512
> +#define CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE 512
>
> #ifndef XKPHYS_TO_PHYS
> -# define XKPHYS_TO_PHYS(p) (p)
> +#define XKPHYS_TO_PHYS(p) (p)
> #endif
This isn't related to the commit message. I'm not sure that it's
really an improvement, either. There is honestly a lot in this
patch which is not necessarily more readable afterwards.
regards,
dan carpenter
next prev parent reply other threads:[~2026-02-10 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 4:36 [PATCH] staging: octeon: type change from uint<bits>_t to u<bits> Yoelvis Oliveros
2026-02-10 4:58 ` Greg KH
2026-02-10 6:50 ` Dan Carpenter [this message]
2026-02-10 10:19 ` David Laight
2026-02-10 10:41 ` Dan Carpenter
2026-02-10 12:28 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYrVPUj1nma3DUPo@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=yoelvisoliveros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.