From: Peter Xu <peterx@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Zhang Chen <zhangckid@gmail.com>,
Hailiang Zhang <zhanghailiang@xfusion.com>,
Markus Armbruster <armbru@redhat.com>,
Li Zhijian <lizhijian@fujitsu.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>
Subject: Re: [PATCH v8 05/17] colo: Remove ENABLE_COLO savevm command and mark it as deprecated
Date: Tue, 10 Feb 2026 12:00:36 -0500 [thread overview]
Message-ID: <aYtkNGvsimVxCwZf@x1.local> (raw)
In-Reply-To: <20260210-colo_unit_test_multifd-v8-5-7f9e5f7d082b@web.de>
On Tue, Feb 10, 2026 at 05:23:03PM +0100, Lukas Straub wrote:
> No need for it anymore now that x-colo capability is required
> on incoming side. There is also no need to send it for backwards
> compatibility since we only support COLO with the same version on
> both sides.
>
> We mark the command code as deprecated and now error out if such
> a unhandled command is encountered in loadvm_process_command().
>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Thanks,
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2026-02-10 17:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 16:22 [PATCH v8 00/17] migration: Add COLO multifd support and COLO migration unit test Lukas Straub
2026-02-10 16:22 ` [PATCH v8 01/17] MAINTAINERS: Add myself as maintainer for COLO migration framework Lukas Straub
2026-02-10 16:23 ` [PATCH v8 02/17] MAINTAINERS: Remove Hailiang Zhang from " Lukas Straub
2026-02-10 16:23 ` [PATCH v8 03/17] colo: Setup ram cache in normal migration path Lukas Straub
2026-02-10 16:23 ` [PATCH v8 04/17] colo: Replace migration_incoming_colo_enabled() with migrate_colo() Lukas Straub
2026-02-10 16:23 ` [PATCH v8 05/17] colo: Remove ENABLE_COLO savevm command and mark it as deprecated Lukas Straub
2026-02-10 17:00 ` Peter Xu [this message]
2026-02-10 16:23 ` [PATCH v8 06/17] ram: Remove colo special-casing Lukas Straub
2026-02-10 16:23 ` [PATCH v8 07/17] multifd: Move ram state receive into multifd_ram_state_recv() Lukas Straub
2026-02-10 16:23 ` [PATCH v8 08/17] multifd: Add COLO support Lukas Straub
2026-02-10 16:23 ` [PATCH v8 09/17] Call colo_release_ram_cache() after multifd threads terminate Lukas Straub
2026-02-10 16:23 ` [PATCH v8 10/17] colo: Fix crash during device vmstate load Lukas Straub
2026-02-10 16:23 ` [PATCH v8 11/17] colo: Hold the BQL while sending ram state Lukas Straub
2026-02-10 16:23 ` [PATCH v8 12/17] colo: Do not hold the BQL while receiving " Lukas Straub
2026-02-10 16:23 ` [PATCH v8 13/17] migration-test: Add COLO migration unit test Lukas Straub
2026-02-10 16:23 ` [PATCH v8 14/17] Convert colo main documentation to restructuredText Lukas Straub
2026-02-10 16:23 ` [PATCH v8 15/17] qemu-colo.rst: Miscellaneous changes Lukas Straub
2026-02-10 16:23 ` [PATCH v8 16/17] qemu-colo.rst: Add my copyright Lukas Straub
2026-02-10 16:23 ` [PATCH v8 17/17] qemu-colo.rst: Simplify the block replication setup Lukas Straub
2026-02-17 13:07 ` Fabiano Rosas
2026-02-17 13:07 ` [PATCH v8 00/17] migration: Add COLO multifd support and COLO migration unit test Fabiano Rosas
2026-02-17 14:14 ` Fabiano Rosas
2026-02-19 13:40 ` Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYtkNGvsimVxCwZf@x1.local \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=farosas@suse.de \
--cc=lizhijian@fujitsu.com \
--cc=lukasstraub2@web.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.