From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: rodrigo.alencar@analog.com
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device resource management
Date: Tue, 10 Feb 2026 22:05:24 +0200 [thread overview]
Message-ID: <aYuPhB_e14orrZ64@smile.fi.intel.com> (raw)
In-Reply-To: <20260210-iio-ad8366-update-v4-7-15505f7b15b4@analog.com>
On Tue, Feb 10, 2026 at 07:42:07PM +0000, Rodrigo Alencar via B4 Relay wrote:
> Adhere modern device resource management with the following:
> - Voltage regulator managed and enabled internally;
> - IIO device registration handled with devm_iio_device_register();
> - removal of goto's from the probe function;
> - ad8366_remove() removed as it is not needed anymore;
>
> With the drop of goto's dev_err_probe() is used to report probe errors.
I think the regulator change should be split and go before the previous patch,
because that one affects the ordering in the error path and remove stage.
Otherwise LGTM.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-10 20:05 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 19:42 [PATCH v4 00/11] iio: amplifiers: ad8366: driver update and dt support Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-10 19:42 ` [PATCH v4 01/11] MAINTAINERS: Add missing maintainer entry for AD8366 driver Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-10 19:42 ` [PATCH v4 02/11] dt-bindings: iio: amplifiers: Add AD8366 support Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-10 19:42 ` [PATCH v4 03/11] iio: amplifiers: ad8366: remove unused include headers Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-10 19:57 ` Andy Shevchenko
2026-02-11 12:55 ` Rodrigo Alencar
2026-02-11 13:35 ` Andy Shevchenko
2026-02-14 18:30 ` Jonathan Cameron
2026-02-15 7:31 ` Andy Shevchenko
2026-02-15 16:03 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 04/11] iio: amplifiers: ad8366: add local dev pointer to the probe function Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-10 19:58 ` Andy Shevchenko
2026-02-10 20:03 ` Andy Shevchenko
2026-02-14 18:34 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 05/11] iio: amplifiers: ad8366: use devm_mutex_init() and drop mutex_init() Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-10 20:00 ` Andy Shevchenko
2026-02-14 18:36 ` Jonathan Cameron
2026-02-15 7:50 ` Andy Shevchenko
2026-02-10 19:42 ` [PATCH v4 06/11] iio: amplifiers: ad8366: replace reset-gpio with reset controller Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-14 18:37 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device resource management Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-10 20:05 ` Andy Shevchenko [this message]
2026-02-11 12:10 ` Rodrigo Alencar
2026-02-11 13:30 ` Andy Shevchenko
2026-02-14 18:44 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 08/11] iio: amplifiers: ad8366: prepare for device-tree support Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-14 18:56 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 09/11] iio: amplifiers: ad8366: add device tree support Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-14 19:00 ` Jonathan Cameron
2026-02-10 19:42 ` [PATCH v4 10/11] iio: amplifiers: ad8366: consume enable gpio Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-10 19:42 ` [PATCH v4 11/11] iio: amplifiers: ad8366: update device support Rodrigo Alencar
2026-02-10 19:42 ` Rodrigo Alencar via B4 Relay
2026-02-14 19:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYuPhB_e14orrZ64@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.