All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Dmitrii Dolgov <9erthalion6@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ian Rogers <irogers@google.com>,
	James Clark <james.clark@linaro.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1] perf test code_with_type.sh: Skip test if rust wasn't available at build time
Date: Wed, 11 Feb 2026 09:25:59 -0300	[thread overview]
Message-ID: <aYx1V443vpL8o7Pv@x1> (raw)
In-Reply-To: <aYqIs-eJeyItVUOm@google.com>

On Mon, Feb 09, 2026 at 05:24:03PM -0800, Namhyung Kim wrote:
> On Mon, Feb 09, 2026 at 03:48:27PM -0300, Arnaldo Carvalho de Melo wrote:
> >   $ perf test 'perf data type profiling tests'
> >    83: perf data type profiling tests                         : Skip
> >   $ perf test -vv 'perf data type profiling tests'
> >    83: perf data type profiling tests:
> >   --- start ---
> >   test child forked, pid 977213
> >   Skip: code_with_type workload not built in 'perf test'
> >   ---- end(-2) ----
> >    83: perf data type profiling tests                         : Skip
> >   $
> > 
> > Cc: Dmitrii Dolgov <9erthalion6@gmail.com>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > ---
> >  tools/perf/tests/shell/data_type_profiling.sh | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/tools/perf/tests/shell/data_type_profiling.sh b/tools/perf/tests/shell/data_type_profiling.sh
> > index a230f5d4c42c3e6a..3ef72a10850d0734 100755
> > --- a/tools/perf/tests/shell/data_type_profiling.sh
> > +++ b/tools/perf/tests/shell/data_type_profiling.sh
> > @@ -4,6 +4,11 @@
> >  
> >  set -e
> >  
> > +if ! perf test --list-workloads | grep -qw code_with_type ; then
> 
> It could be 'perf check feature -q rust'.

Right, better, more compact and using something that was designed for
that...
 
> But IIUC this test also covers C code.  We may want to skip Rust parts
> only.

I'll cook up a patch implementing your suggestions.

- Arnaldo

> Thanks,
> Namhyung
> 
> 
> > +	echo "Skip: code_with_type workload not built in 'perf test'"
> > +	exit 2
> > +fi
> > +
> >  # The logic below follows the same line as the annotate test, but looks for a
> >  # data type profiling manifestation
> >  
> > -- 
> > 2.53.0
> > 

      reply	other threads:[~2026-02-11 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 18:48 [PATCH 1/1] perf test code_with_type.sh: Skip test if rust wasn't available at build time Arnaldo Carvalho de Melo
2026-02-10  1:24 ` Namhyung Kim
2026-02-11 12:25   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYx1V443vpL8o7Pv@x1 \
    --to=acme@kernel.org \
    --cc=9erthalion6@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.