Re: [PATCH 1/5] xen/x86: always consider '/' as a division in assembly

["Roger Pau Monné" <roger.pau@citrix.com>]

On Wed, Feb 11, 2026 at 12:11:32PM +0100, Jan Beulich wrote:
> On 11.02.2026 11:46, Roger Pau Monne wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -413,6 +413,13 @@ ifneq ($(CONFIG_CC_IS_CLANG),y)
> >  CFLAGS += -Wa,--strip-local-absolute
> >  endif
> >  
> > +ifeq ($(CONFIG_X86),y)
> > +# The GNU assembler will interpret '/' as a comment start marker instead of a
> > +# divide for some ELF targets.  Pass --divide when when available to signal '/'
> > +# is always used as an operator in assembly.
> > +$(call cc-option-add,CFLAGS,CC,-Wa$$(comma)--divide)
> > +endif
> 
> As said before, I don't think this should be put here. Not even with the
> new ifeq(,) around it. It should go in x86/arch.mk, or a reason should be
> given why it can't.

My bad.  I've attempted to put it there but got complains from the
build in x86/boot/.  I think that was because I had leftover stale
objects in there, and nothing do to with the patch itself.  I can
confirm it works when the chunk is placed in x86/arch.mk.

Thanks, Roger.