From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011012.outbound.protection.outlook.com [52.101.62.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 693D136EABD for ; Wed, 11 Feb 2026 21:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770844061; cv=fail; b=DLYEpaKmdghZv6IRB7Wnb9UT/cA4Nnk285qqc0MhBKXQ5RnbZtGonLdz3f+3l/RsUzWS7i5ejHDh/E8SD8fRiw8ynJ8t1WejSGtzCV0qdYpf+j3TsuMZ3gpCgTFFciBryziqWZeAh8BQppbqW6o4Ijc8Qdiyo0M1ykaHFkKaFMI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770844061; c=relaxed/simple; bh=BPAWbfXRaEfayKd9J8QQxKDV9Sgq9wOp4u3hy15CQkQ=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=snP86+UV5ta6f6DxCMPw6Sju/0Rsy0TuaqtiAt7ATQddn28rGyWWcYWDmmAZXgcoB+UgpCWtfmO4/QnZjG3ILncGQ2UkLPTuThiyUnnZBmMnTuu1RkkO2jzeKuezuZEkjJo3XoD6Nx30tlzCLUXr8QOeM8rTmVVkJs9s0Q6rsLs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=l/C0Ft8Y; arc=fail smtp.client-ip=52.101.62.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="l/C0Ft8Y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mzHqhb4mh5jdLoFCTmF4P82/og0fxbJ6y3gRcIs8B0rgV9DKA9H1WQGdYHPClbFm6kAQ9LK2yVv7lyug9p2+/77tzxkztIdcc+OXcmoFEd2bb/uxXIsmgucdFOC4YzncD6ZcuzT2GfqqDrNaDxZq5MIbaCqqyyV8jHWBxY+I1mnxLvS+MmCXWAhbcuVedSLlXZ/zU/9dYQ7nWcw+hztF2kAmsuqg9hcdc2pD8ahP7J4PJpFyJeuJgrU4K8go+QrnfguIfoWgBQTyMHuk7hDKqGj0W+CURDygbr+s2/U+wamOpfW1plGhFMCaKvcRADnDUvBeZW/mp0OoXsN4+nKJ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TkfUGkts3N6mD6vPVTzbV56HIlZSIe8b8KxhOXd3Csg=; b=WZMKGYnoogmFXcLZ1qtokmgDOHS8usLP6lKZ0w/TQSppK/RDFcsO/GhzkLqN1UBi4zZ6dOIms/BL5lwkD/ij4bQieKikZ0Vbb2dAIMKZ3Hq/t49tIWwfpTvfHxVKalKxIx5XK9V97vrZQC5eRgOKpSfFekq1sYqzytI0n8mT3O7ExexgUKbFojV6OvUf71hJXOAicJXbWRwfz7HG4F6GTiuU9QwMfcKKDIOO88tmx6kYDGo4T106OUHasIiAmhebxsBfoZHfAPRDqSkRWX5YWtqvnuH+YaltMJ1JUekC1ydNUvhD85g0AcTYH12kM1Yr1KsdzGCugIHei0Di8sDoeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TkfUGkts3N6mD6vPVTzbV56HIlZSIe8b8KxhOXd3Csg=; b=l/C0Ft8YxLrfX9a5exIi8D2q8gkoEWZAFALoRKfN2PP7HGbfPWDElW5o2/yi1aFY+Kv6XSy/Q1w/vvrUXoKLMQHxoxpeZm8cY+ekLaX+ZkWe94BliWMzCviwoCzp/zocVklivkASQNrQTdLt2wnkFBc0JliRtT973gjuIwHuqcFSHU+884yw2PBjypn09q5qFAqZInMgtBYa4b2VwNjhtDDZyNqmmAGhs73Ssy5CBcxkfHtLj0GV2IcHo5jGhHwiRL41HrTSXCVMtXk+0GLGpuE7Zbw0H5hKz+mz6bXrdqUtwqK2wKqrPOXuHjGuGWGdBj8rUkHvI6jP34xPEGKMWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from PH0PR12MB8800.namprd12.prod.outlook.com (2603:10b6:510:26f::12) by MW5PR12MB5621.namprd12.prod.outlook.com (2603:10b6:303:193::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.19; Wed, 11 Feb 2026 21:07:35 +0000 Received: from PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::f79d:ddc5:2ad7:762d]) by PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::f79d:ddc5:2ad7:762d%4]) with mapi id 15.20.9587.017; Wed, 11 Feb 2026 21:07:35 +0000 Date: Wed, 11 Feb 2026 16:07:20 -0500 From: Yury Norov To: Arnd Bergmann Cc: Matt Wu , Arnd Bergmann , Yury Norov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] objpool: fix minimum alignment of 'struct objpool_slot' Message-ID: References: <20260210103530.3028454-1-arnd@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260210103530.3028454-1-arnd@kernel.org> X-ClientProxiedBy: BN0PR04CA0004.namprd04.prod.outlook.com (2603:10b6:408:ee::9) To PH0PR12MB8800.namprd12.prod.outlook.com (2603:10b6:510:26f::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR12MB8800:EE_|MW5PR12MB5621:EE_ X-MS-Office365-Filtering-Correlation-Id: f115d040-af23-4e33-190c-08de69b19433 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fxjHzQbytosfQ5hz7HOVBcArq3+KIc2jsHvNWWQWWfLP46ul1hJJ2qcSfHDD?= =?us-ascii?Q?0pDc39NKXBstpi55GTXVFOm0ewN6BCZmJHJHTv3HcIWO322wPcRHfGd3izlD?= =?us-ascii?Q?vwHNvvgxJ0hK4vdE9r+YpUJJVITstlU8caMrbp9HsPBR6LCS4KsYV3Px8lxT?= =?us-ascii?Q?fzskbhNTNVClJsvGVXaKNXnTRlcPb092qD2ejalbXVmaaUTeMN8AgM2zt/Aw?= =?us-ascii?Q?vSZgr+/lIA3Owo6iojXhk6pR6+ed87DbV58jJKLbNg8q790y29UYz+Tr/XPb?= =?us-ascii?Q?XFYDVDXxaScHDNueeqnlGDLx23/yJEe1FLQcsvOo8ar9CsOMedGnBuNnvfLV?= =?us-ascii?Q?Nw+EF0fjmJBGLByQwZwMz0LdIdA5CC65xiGe7RI0RUiaeMc451qRHlpXitvL?= =?us-ascii?Q?in2a6V0ctfvgoJVJsSvlkaUVj8M5c+yKoIPsgS/5zgSuF67ZqPRd+C9VMDk8?= =?us-ascii?Q?l0mcscG1Q0hndcWz2FvI79py+PhljOAyCOrCN+QIXiwsm5VV6pM6d6DASgx3?= =?us-ascii?Q?THN+/0Zba/gYp3b+KnJ+X8foWduc0cll3F0f2j4yxKLp8KSMa0hpSqgkKwVK?= =?us-ascii?Q?8cH46bevijYAJ0gbBv5p+1bWU9etusZjYn0VqYzHZs8QekLCB70G+qJkIWuX?= =?us-ascii?Q?cjmG8n25dGZ3A+ih9I9UES+owhWTeHFJ/7/d4yhlIzaieuMm6rlfyKImSjrs?= =?us-ascii?Q?tmhojNqTs8MgFBlMTSQ58is4FHhYk6iR9EnU1wzTCoDCGDW20UHjOzry0OD5?= =?us-ascii?Q?2Ha7ASAonHeD1Jo0gHRhXTqasUzt/lbT8bTaKjSslHBvM6qsklqw11YUNalL?= =?us-ascii?Q?4Z69mVXuPlKIis0ZHbfyxnH4fv3DnjbnNuyzrc/AS9tXDzLU+uRDuzQQGQ8z?= =?us-ascii?Q?w36E1BMLKt7wunGDLxlwKpQxFo9ARiovG/4hByTM5l1GHnDsDwwbENofRhre?= =?us-ascii?Q?MRSwLWUjDZYXNEe1uyAAYGmg90AJQBaVBsH0QO2CMb10eNPxTXjSz3+m1QKM?= =?us-ascii?Q?lOohQjDKFoQzXxsMrClLB/4FrKJuLA9epxs7zlzpvrTxpNex8w00kRtsWMVZ?= =?us-ascii?Q?Ji+QjqVgj6R4Z3K2NSq7xP5ZH7l9R7EJRRlkZrgzk002hfNw3iqRw/ktSsdl?= =?us-ascii?Q?WIW5AsxRBMnQ7MWCjU39RlFkOFYmLiuCc9CdAw/w43PQsL/RggVVQHEhHfN7?= =?us-ascii?Q?Zz/WfUlVU0y4EBAdBjFjGC7hDfDA1qWvbXVhQS1b0Ee9bDlMkJDtahvn1wGM?= =?us-ascii?Q?NEf2TpZgVoiqq0VUDupdQLqipcD3A1tUinPeePyQcNXffBQIZ5Q85Q/WztbH?= =?us-ascii?Q?OPBUNnKJ5pQtboQ4aevOnXQ9TN7dL9oR4Evsh4yZyo3OH9Velmoy1l0W/Qov?= =?us-ascii?Q?hkTh2sXPG27agehZlh8jcqEfK3HORnVRLxiALROj1Hne+T+EQuYZSDByuXEt?= =?us-ascii?Q?1osevYaynDzdIgM8zkN4uNIADFfZIPVtHVN/gU1Fnz+JyhU/Vwvk+yg/3bID?= =?us-ascii?Q?clY7iZm526GMfl4W7RGPl92CrBnwTX+jCm21vK13cVboPRDK+ii8Uuht/6i2?= =?us-ascii?Q?1FkEXbMPJsjY+SYeHvs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR12MB8800.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qJF7kc9LZTmrsPlmpbyeCtgtKADSoRpAlgnH9IFo5+9oz69gRCzcw1Kfp5By?= =?us-ascii?Q?+LjA5jJQOGZJPta02m/I9NpzEf73fkbAh8l1dI0Q5nPLxO4mIisRAwxVq7yI?= =?us-ascii?Q?EkPoJu1HRrqqQARAsxq5wnXLHhJR/Dy2UWJ/mGls7CQ0MAT9fxvNHISyA9fG?= =?us-ascii?Q?ur2pmRBFvjuK+G0b5NA9yeWJYdHd01guqWWrttVf9peGR5eFQ15lX512wGE2?= =?us-ascii?Q?LRFtahA4FHXV5riUzSpSNvtporH2T5i+NM6S8XGgwSmVxBaRDgSNUzCM7f3o?= =?us-ascii?Q?/2+KNNJPprlMEw9BQRFl2Lt1Od/P2bXmK6b5nly86JXwxhg6p//ysNFf0w5N?= =?us-ascii?Q?9VosOMNQw6q3miqWbsPdQ7/HVmZOoIEcf8B/K6wEGZh4m2+HTGjc1i9BSIO5?= =?us-ascii?Q?MfcXfCsmmCxF9Wk6BnMRKnE0jutbpLsyWnoig0xcH0fsMmnGSFL2+gmn0oHs?= =?us-ascii?Q?oYEJPcE9fJW0dl4zbyx2oE0+9i1I5TsjcWMfeGtdeUIjciczslfX7MyvCNUJ?= =?us-ascii?Q?KgNuIgPfkwZlV93GewDERHosO7dkDhghIoAnp3ZTHz0p9qXP46vJDr/RpHXu?= =?us-ascii?Q?o/PrAtqWBsW2TZTBgrwaAVAxX6oxPuHl4MzRqMCaMZpQjT5CTV4m5wBQksff?= =?us-ascii?Q?T/gLa9HlSIBrDMruHS6fn5+VfmCFJkS1FQdsfMHu4EkHPEKxiZasHW/FFjqt?= =?us-ascii?Q?vcYLWtP6nR2gctDn3XwZl7vspvgvq6lL+g3jfdEmwLG5DHH2xVBmrOf4xCN9?= =?us-ascii?Q?dtER+/lZqJ3/s3UzZ0syCtTJKjbqDXMRfSrZlKMH7PsQBG+9i7KnNMQeTFg1?= =?us-ascii?Q?2t5IsVNvsbaL7iMxJa+YQvav85xGX3b2j/1pTMgN3VQVXdPkHuuSqSvp4F/l?= =?us-ascii?Q?bg6+Ne4iDIK9HmDRtTxI5S6Odt+981rke/mBjFBtDw0g6LTFpExAFR7ATzA9?= =?us-ascii?Q?08ZxLhEg6FmRwUVNtCL5yzqJJJXkXuOk7jGTfvwWftpkBGa+poir3GyvF5Sw?= =?us-ascii?Q?yCwgp9cJ/feBNNtdaITd7gu8HLrXvsFTH8SXGkEWmYbIck4bkb8536RmKStT?= =?us-ascii?Q?0FX/9XAAT93SStoFnJLtTBFyZnPUrnCLr31MFtys4XoLVne/4XnNpFigj6uS?= =?us-ascii?Q?5zB1laUI27fZ3V2S5O3eTUwW3pvHhkdScRc/wUz/tUiNUlW0CYBjf8K1+RkA?= =?us-ascii?Q?fsqJgiLvn2Ap2egexcqBP4ieKtqpRb3id3wHBHUWW+lu1scHxbsHLIpcsi5P?= =?us-ascii?Q?2bgiV0+K6d0ZWAJjyMwa+j5tNbaUtpDGkhjzHsbDOA1+5smpzpJzx1tJO/kN?= =?us-ascii?Q?eg4fcvmy2zQ2pDE78ue0DBF3mt9MVAYqO5ySSzFgAdRqhW88fsLr9sSjCDtC?= =?us-ascii?Q?7n+te//q8Cw9XKMqVk+3N9VTQCWC9MlY4d9GNS4u9j82RJt8PARJXLm9rvMK?= =?us-ascii?Q?l93fAh+SzkuI6nNWhazqYwPNh/9ImuNAUwzcEKaIUGJdyU9Aqu+5s+afLDle?= =?us-ascii?Q?jOZQwV1z7i0fa0+hhjySjKow1m4CcBkFKVjcnFZmW390S4/HvZc9brhBki/q?= =?us-ascii?Q?2iAgS1xWucIhFCmMuAAzXVfIZN+W33GDv574zSCGPfT49AYF7Q6KpKTH/ddH?= =?us-ascii?Q?WNF7FbZd5DRw5YKSKw8X75nclcIIhtUwtKa4yn2B6ANFyErE/UmikTxyk71b?= =?us-ascii?Q?rqTPqqg6g0ekG6Yj1qXA+YsZyb/tCl0g80pYB8LRyklLTLwGVsvpO3/q1aBl?= =?us-ascii?Q?yq8N3XPcwg3Z5FhIe1e5XJtvT7B9vKaMRCk4iBlFqqu+oa0sLLOa?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f115d040-af23-4e33-190c-08de69b19433 X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB8800.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2026 21:07:35.2618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fdvX2g3mQFOUBhr9HR25PMle/A2GWOVirH9CiqAEkqN/k/TS0kFJwd1FTEFZ0Oa1DUFOu1XupojNy9uSQidChw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5621 On Tue, Feb 10, 2026 at 11:35:24AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Members of objpool_slot get passed into try_cmpxchg_release(), > which does not work on most architectures unless they are > naturally aligned. Marking the structure as packed makes it > only byte-aligned, as shown by this (normally disabled) warning: > > include/linux/objpool.h:156:56: warning: taking address of packed member of 'struct objpool_slot' may result in an unaligned pointer value [-Waddress-of-packed-member] > 156 | if (try_cmpxchg_release(&slot->head, &head, head + 1)) > | ~^~~~~~~~~~~~ > > As the struct members are all tightly packed on all architectures, > Just remove the '__packed annotation to give it the required > alignment of the native word size. > > Signed-off-by: Arnd Bergmann Reviewed-by: Yury Norov > --- > include/linux/objpool.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/objpool.h b/include/linux/objpool.h > index b713a1fe7521..f678b35b20b1 100644 > --- a/include/linux/objpool.h > +++ b/include/linux/objpool.h > @@ -56,7 +56,7 @@ struct objpool_slot { > uint32_t last; > uint32_t mask; > void *entries[]; > -} __packed; > +}; > > struct objpool_head; > > -- > 2.39.5