All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2-next] iplink: bond_slave: print actor and partner churn state
Date: Thu, 26 Feb 2026 02:10:21 +0000	[thread overview]
Message-ID: <aZ-rjaU32FbTbn9I@fedora> (raw)
In-Reply-To: <20260225132239.34fba967@phoenix.local>

On Wed, Feb 25, 2026 at 01:22:39PM -0800, Stephen Hemminger wrote:
> On Tue, 24 Feb 2026 02:02:15 +0000
> Hangbin Liu <liuhangbin@gmail.com> wrote:
> 
> > +	if (tb[IFLA_BOND_SLAVE_AD_CHURN_ACTOR_STATE]) {
> > +		__u8 state = rta_getattr_u8(tb[IFLA_BOND_SLAVE_AD_CHURN_ACTOR_STATE]);
> > +
> > +		if (state >= ARRAY_SIZE(port_churn_state))
> > +			print_int(PRINT_ANY, "churn_actor_state", "churn_actor_state %u ", state);
> 
> You should use print_uint for unsigned values.

Thanks, should I post a v2 version for both the kernel and iproute2 patches,
Or just the iproute2 patch?

Hangbin

  reply	other threads:[~2026-02-26  2:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  2:02 [PATCH net-next] bonding: print churn state via netlink Hangbin Liu
2026-02-24  2:02 ` [PATCH iproute2-next] iplink: bond_slave: print actor and partner churn state Hangbin Liu
2026-02-25 21:22   ` Stephen Hemminger
2026-02-26  2:10     ` Hangbin Liu [this message]
2026-02-26  3:03       ` Jakub Kicinski
2026-02-26  3:35         ` Hangbin Liu
2026-02-26 11:00 ` [PATCH net-next] bonding: print churn state via netlink patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ-rjaU32FbTbn9I@fedora \
    --to=liuhangbin@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.