From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: "Linus Walleij" <linusw@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Multiple bug fixes
Date: Tue, 24 Feb 2026 12:08:04 +0200 [thread overview]
Message-ID: <aZ14hOnF_EKa8MSc@smile.fi.intel.com> (raw)
In-Reply-To: <20260224023511.274038-1-ethantidmore06@gmail.com>
On Mon, Feb 23, 2026 at 08:35:07PM -0600, Ethan Tidmore wrote:
> This series fixes 4 bugs:
> - Patch 1: Fix free_irq() being called with wrong handler.
> - Patch 2: Added missing free_irq() in an error path.
> - Patch 3: Moved iio_device_register() to end of probe function, in
> doing so had to implement correct error cleanups and place
> iio_device_unregister in beginning of remove callback.
> - Patch 4: free_irq() is after called iio_triggered_buffer_cleanup()
> which breaks LIFO, place it before it.
All good, except one stray change and some work needed in the commit messages.
> I plan on doing a proper devm_ conversion of this driver, but went ahead
> and did these fixes so they could be backported.
This would be nice!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-24 10:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 2:35 [PATCH v2 0/4] Multiple bug fixes Ethan Tidmore
2026-02-24 2:35 ` [PATCH v2 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable Ethan Tidmore
2026-02-24 9:55 ` Linus Walleij
2026-02-24 10:02 ` Andy Shevchenko
2026-02-24 2:35 ` [PATCH v2 2/4] iio: gyro: mpu3050: Fix irq resource leak Ethan Tidmore
2026-02-24 9:56 ` Linus Walleij
2026-02-24 10:03 ` Andy Shevchenko
2026-02-24 2:35 ` [PATCH v2 3/4] iio: gyro: mpu3050: Move iio_device_register() to correct location Ethan Tidmore
2026-02-24 9:56 ` Linus Walleij
2026-02-24 10:05 ` Andy Shevchenko
2026-02-24 2:35 ` [PATCH v2 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq() Ethan Tidmore
2026-02-24 9:57 ` Linus Walleij
2026-02-24 10:06 ` Andy Shevchenko
2026-02-24 2:42 ` [PATCH v2 0/4] Multiple bug fixes Ethan Tidmore
2026-02-24 10:08 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ14hOnF_EKa8MSc@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ethantidmore06@gmail.com \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.