From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Zijun Hu <zijun.hu@oss.qualcomm.com>,
linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
linux-acpi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Danilo Krummrich <dakr@kernel.org>, Len Brown <lenb@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v1 1/3] driver core: Split device data types to device/types.h
Date: Tue, 24 Feb 2026 11:05:38 +0200 [thread overview]
Message-ID: <aZ1p4lgioFlxhFr_@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0gS6kyCOmwL-9JYiaxCDVubtBoK6Rb5NSgHD1GwkGoCRA@mail.gmail.com>
On Mon, Feb 23, 2026 at 09:53:17PM +0100, Rafael J. Wysocki wrote:
> On Mon, Feb 23, 2026 at 9:44 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > device.h is a huge header which is hard to follow and easy to miss
> > something. Improve that by splitting device data types to device/types.h.
> >
> > In particular this helps to speedup the build of the code that includes
> > device.h solely for a device data types.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> But why do you want to move the struct device definition out of device.h?
Because it's a data type, and we have many drivers that may require it
(embed the struct device), but no device.h API is called directly —
only via a certain framework).
device.h also includes many unrelated headers in such a case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-24 9:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 20:30 [PATCH v1 0/3] driver core: Split device.h even more Andy Shevchenko
2026-02-23 20:30 ` [PATCH v1 1/3] driver core: Split device data types to device/types.h Andy Shevchenko
2026-02-23 20:53 ` Rafael J. Wysocki
2026-02-24 9:05 ` Andy Shevchenko [this message]
2026-02-24 12:21 ` Rafael J. Wysocki
2026-02-24 13:17 ` Greg Kroah-Hartman
2026-02-24 13:47 ` Danilo Krummrich
2026-02-24 14:02 ` Andy Shevchenko
2026-02-24 14:30 ` Rafael J. Wysocki
2026-02-24 14:01 ` Andy Shevchenko
2026-02-24 14:34 ` Greg Kroah-Hartman
2026-02-23 20:30 ` [PATCH v1 2/3] driver core: Split device link data types and API to device/devlink.h Andy Shevchenko
2026-02-23 21:00 ` Rafael J. Wysocki
2026-02-23 20:30 ` [PATCH v1 3/3] driver core: Split device related fwnode API to device/fwnode.h Andy Shevchenko
2026-02-23 20:51 ` Rafael J. Wysocki
2026-02-24 0:33 ` Greg Kroah-Hartman
2026-02-24 9:03 ` Andy Shevchenko
2026-02-24 0:32 ` [PATCH v1 0/3] driver core: Split device.h even more Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ1p4lgioFlxhFr_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=zijun.hu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.