From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: Antoniu.Miclaus@analog.com, Nuno.Sa@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: ade9000: fix wrong return type in streaming push
Date: Tue, 24 Feb 2026 16:47:34 +0200 [thread overview]
Message-ID: <aZ26BgzCKcssGPOZ@smile.fi.intel.com> (raw)
In-Reply-To: <20260224132354.76672-2-giorgitchankvetadze1997@gmail.com>
On Tue, Feb 24, 2026 at 05:23:55PM +0400, Giorgi Tchankvetadze wrote:
> The else branch of ade9000_iio_push_streaming() incorrectly returns
> IRQ_HANDLED on regmap_write failure. This function returns int (0 on
> success, negative errno on failure), so IRQ_HANDLED (1) would be
> misinterpreted as a non-error by callers.
>
> Return ret instead, consistent with every other error path in the
> function.
Again, do NOT start a _new_ version in the _previous_ version email thread.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-24 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 12:59 [PATCH] iio: adc: ade9000: fix wrong return type in streaming push Giorgi Tchankvetadze
2026-02-24 13:09 ` Miclaus, Antoniu
2026-02-24 14:49 ` Andy Shevchenko
2026-02-24 13:23 ` [PATCH v2] " Giorgi Tchankvetadze
2026-02-24 13:30 ` Miclaus, Antoniu
2026-02-24 14:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ26BgzCKcssGPOZ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Antoniu.Miclaus@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.