From: Simon Horman <horms@kernel.org>
To: kexinsun <kexinsun@smail.nju.edu.cn>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, julia.lawall@inria.fr,
xutong.ma@inria.fr, yunbolyu@smu.edu.sg, ratnadiraw@smu.edu.sg
Subject: Re: [PATCH] net/hsr: update outdated comment
Date: Tue, 24 Feb 2026 17:36:48 +0000 [thread overview]
Message-ID: <aZ3hsP_GoUN8Yn-7@horms.kernel.org> (raw)
In-Reply-To: <20260224021205.1285-1-kexinsun@smail.nju.edu.cn>
On Tue, Feb 24, 2026 at 10:12:05AM +0800, kexinsun wrote:
> The function hsr_rcv() was renamed hsr_handle_frame() and moved to
> net/hsr/hsr_slave.c by commit 81ba6afd6e64 ("net/hsr: Switch from
> dev_add_pack() to netdev_rx_handler_register()"). Update the comment
> accordingly.
>
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
I notice that you have sent a number of similar fixes recently.
I am curious to know how you found these problems.
If you are using a tool, please consider using the Assisted-by tag:
https://docs.kernel.org/process/coding-assistants.html
Also, both git grep and our AI generated code review
tell me that this is not the only instance of hsr_rcv lingering
in comments in this driver. Please update all of them.
--
pw-bot: changes-requested
prev parent reply other threads:[~2026-02-24 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 2:12 [PATCH] net/hsr: update outdated comment kexinsun
2026-02-24 17:36 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ3hsP_GoUN8Yn-7@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=julia.lawall@inria.fr \
--cc=kexinsun@smail.nju.edu.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ratnadiraw@smu.edu.sg \
--cc=xutong.ma@inria.fr \
--cc=yunbolyu@smu.edu.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.