All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@kernel.org>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE
Date: Wed, 25 Feb 2026 10:48:56 +0800	[thread overview]
Message-ID: <aZ5jGLX9cBQPLn_d@fedora> (raw)
In-Reply-To: <20260224155724.3142007-1-csander@purestorage.com>

On Tue, Feb 24, 2026 at 08:57:22AM -0700, Caleb Sander Mateos wrote:
> The ublk driver doesn't access request integrity buffers directly, it
> only copies them to/from the ublk server in ublk_copy_user_integrity().
> ublk_copy_user_integrity() uses bio_for_each_integrity_vec() to walk all
> the integrity segments. ublk devices are therefore capable of handling
> requests with integrity intervals split across segments. Set
> BLK_SPLIT_INTERVAL_CAPABLE in the struct blk_integrity flags for ublk
> devices to opt out of the integrity-interval dma_alignment limit.
> 
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> ---
>  drivers/block/ublk_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 004f367243b6..34ed4f6a02ef 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -806,11 +806,11 @@ static void ublk_dev_param_basic_apply(struct ublk_device *ub)
>  	set_capacity(ub->ub_disk, p->dev_sectors);
>  }
>  
>  static int ublk_integrity_flags(u32 flags)
>  {
> -	int ret_flags = 0;
> +	int ret_flags = BLK_SPLIT_INTERVAL_CAPABLE;
>  
>  	if (flags & LBMD_PI_CAP_INTEGRITY) {
>  		flags &= ~LBMD_PI_CAP_INTEGRITY;
>  		ret_flags |= BLK_INTEGRITY_DEVICE_CAPABLE;

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks, 
Ming


  parent reply	other threads:[~2026-02-25  2:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 15:57 [PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE Caleb Sander Mateos
2026-02-24 16:00 ` Keith Busch
2026-02-24 21:18 ` Martin K. Petersen
2026-02-25  2:48 ` Ming Lei [this message]
2026-02-25 15:37 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ5jGLX9cBQPLn_d@fedora \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.