All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-eh: avoid unnecessary calls to ata_scsi_port_error_handler()
Date: Wed, 25 Feb 2026 07:22:38 +0100	[thread overview]
Message-ID: <aZ6VKXgj2sNPTOu4@ryzen> (raw)
In-Reply-To: <20260224020638.1194842-1-dlemoal@kernel.org>

On Tue, Feb 24, 2026 at 11:06:38AM +0900, Damien Le Moal wrote:
> When handling SCSI command timeouts, if we had no actual command
> timeouts (either because the command was a deferred qc or the completion
> path won the race with ata_scsi_cmd_error_handler()), we do not need to
> go through a port error handling, as there was in fact no errors at all.
> 
> Modify ata_scsi_cmd_error_handler() to return the number of commands
> that timed out and use this return value in ata_scsi_error() to call
> ata_scsi_port_error_handler() only if we had command timeouts, or if
> the port EH has already been scheduled due to failed commands.
> Otherwise, simply call scsi_eh_flush_done_q() to finish the completed
> commands without running the full port error handling.
> 
> 

Applied to libata/linux.git (for-7.1), thanks!

[1/1] ata: libata-eh: avoid unnecessary calls to ata_scsi_port_error_handler()
      https://git.kernel.org/libata/linux/c/46a9d970

Kind regards,
Niklas

      parent reply	other threads:[~2026-02-25  6:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  2:06 [PATCH] ata: libata-eh: avoid unnecessary calls to ata_scsi_port_error_handler() Damien Le Moal
2026-02-24 14:08 ` Niklas Cassel
2026-02-24 20:59   ` Damien Le Moal
2026-02-24 21:21 ` Martin K. Petersen
2026-02-25  6:22 ` Niklas Cassel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ6VKXgj2sNPTOu4@ryzen \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.