From: Oleg Nesterov <oleg@redhat.com>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc: Andrei Vagin <avagin@gmail.com>,
Christian Brauner <brauner@kernel.org>,
Shuah Khan <shuah@kernel.org>, Kees Cook <kees@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Jan Kara <jack@suse.cz>, Aleksa Sarai <cyphar@cyphar.com>,
Andrei Vagin <avagin@google.com>, Kirill Tkhai <tkhai@ya.ru>,
Alexander Mikhalitsyn <alexander@mihalicyn.com>,
Adrian Reber <areber@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 2/4] pid: check init is created first after idr alloc
Date: Wed, 25 Feb 2026 14:06:45 +0100 [thread overview]
Message-ID: <aZ7z5XPAtptQVoW0@redhat.com> (raw)
In-Reply-To: <6269de34-203d-47b5-922b-342671573b7f@virtuozzo.com>
On 02/25, Pavel Tikhomirov wrote:
>
> On 2/25/26 10:06, Oleg Nesterov wrote:
> > On 02/24, Andrei Vagin wrote:
> >>
> >> I don't think this is an issue right now, as we only allow one attempt
> >> to create the init. If that first attempt fails, free_pid will disable
> >> further PID allocations in the target namespace.
> >
> > Thanks, you are right!
>
> I guess it means that we should change the commit message a bit, e.g.: replace
> "Effectively leading ..." to "Though thanks to PIDNS_ADDING logic, free_pid()
> disables further pid allocation in this case and it does not lead to any real
> problem.".
Agreed,
> Please advise if I should resend the whole series (v4) for that?
This is a question for Andrew ;)
I guess you can just send a single [PATCH v4 2/4] in reply to v3, but it won't
hurt if you resend the whole series.
Oleg.
next prev parent reply other threads:[~2026-02-25 13:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 16:47 [PATCH v3 0/4] pid_namespace: make init creation more flexible Pavel Tikhomirov
2026-02-24 16:47 ` [PATCH v3 1/4] pid_namespace: avoid optimization of accesses to ->child_reaper Pavel Tikhomirov
2026-02-25 12:24 ` Oleg Nesterov
2026-02-24 16:47 ` [PATCH v3 2/4] pid: check init is created first after idr alloc Pavel Tikhomirov
2026-02-25 0:23 ` Andrei Vagin
2026-02-25 9:06 ` Oleg Nesterov
2026-02-25 10:20 ` Pavel Tikhomirov
2026-02-25 13:06 ` Oleg Nesterov [this message]
2026-02-25 13:37 ` Pavel Tikhomirov
2026-02-26 12:46 ` Oleg Nesterov
2026-02-26 14:02 ` Oleg Nesterov
2026-02-26 16:07 ` Oleg Nesterov
2026-02-25 8:47 ` Oleg Nesterov
2026-02-25 8:57 ` Oleg Nesterov
2026-02-24 16:47 ` [PATCH v3 3/4] pid_namespace: allow opening pid_for_children before init was created Pavel Tikhomirov
2026-02-25 12:55 ` Oleg Nesterov
2026-02-24 16:47 ` [PATCH v3 4/4] selftests: Add tests for creating pidns init via setns Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ7z5XPAtptQVoW0@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander@mihalicyn.com \
--cc=areber@redhat.com \
--cc=avagin@gmail.com \
--cc=avagin@google.com \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=david@kernel.org \
--cc=jack@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=shuah@kernel.org \
--cc=tkhai@ya.ru \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.