From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7A93D5258 for ; Wed, 25 Feb 2026 15:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772034767; cv=none; b=uTSAzygoWE0Hv2SCo9KxXq2jg56mNqUrEa9+1mKmWwyv3MuBfzQ9QU9ExxVfR8nQVUk8cu1SsNsnchVsR3BPEpembo5wMuTwshDWsAXpPk5dU3JW73/qgMR5u6Hbta4BDERKufoQNFAwUJN3+OAIfckrG6/+n+/jYUF1DZbYuEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772034767; c=relaxed/simple; bh=UBRGkIm53Xo8QDklKKx5MPucEgbQ6wBkoCckBrCq3TE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bto87BhB8NkJYpf3CDDr4cwRtrD+92+Ntp6dsH/5vCmsQYGnPt7Rm5jFJlcThEg+shkHEei0fnXRWE/iwvZUXT0jnZseh8eL4WHtLfCNlJXCSNyjigh/DAq6npRNELUocF95J0Cwvt40QAMsEB0hYm3l5bCzmmibuTCw5QXVn+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DD9jJem1; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DD9jJem1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772034765; x=1803570765; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UBRGkIm53Xo8QDklKKx5MPucEgbQ6wBkoCckBrCq3TE=; b=DD9jJem1hnV4Sy5ay7GPgXJzzwCsdf9HWbq6KZ35s9dk8jlpxgGHKzC8 234AS9Zmw0KgdTJqFZK0wAT65NXCVw7tCSqgUvL2F2atdOXtnnqAtUVPp AOQGfnlEbl2OIq+H//3TUafTfsO1OschYWtyDPZLR9tM0Xd0Ka+H5uCd7 Df6hFkyBRSi3fRkdDxsL8u1JeYIP/ksmp9I6HDFMoZe3TlNeIISLLFd4+ Z8DTQqt51FKfSnWMgqt6P7UqyNViN+sgNXN08fh/BwNfT3L5XPHqWzIkj Lxgd5l5lMmGUP5q4hhyI1y6iFfk9On+7wSvmOonTzAESFcqerbjpaOZqw g==; X-CSE-ConnectionGUID: 6fblHlBVREmGMQ9mkxZu6w== X-CSE-MsgGUID: rN1t9x/eTnCblRov69XCHQ== X-IronPort-AV: E=McAfee;i="6800,10657,11712"; a="60649794" X-IronPort-AV: E=Sophos;i="6.21,310,1763452800"; d="scan'208";a="60649794" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2026 07:52:45 -0800 X-CSE-ConnectionGUID: o19iSUXdT6aI+1hb/FrmcQ== X-CSE-MsgGUID: 6UH+U9lJR9Wqcma3Y9AVAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,310,1763452800"; d="scan'208";a="220771369" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.244.71]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2026 07:52:43 -0800 Date: Wed, 25 Feb 2026 17:52:40 +0200 From: Andy Shevchenko To: Neel Bullywon Cc: apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, andy@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] checkpatch: mention fsleep() in MSLEEP and USLEEP_RANGE warnings Message-ID: References: <20260220230555.70073-1-neelb2403@gmail.com> <20260225152135.7709-1-neelb2403@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225152135.7709-1-neelb2403@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Feb 25, 2026 at 10:21:35AM -0500, Neel Bullywon wrote: > Expand the USLEEP_RANGE check to recommend fsleep() as the preferred > option over both usleep_range() and udelay(), and expand the MSLEEP > warning to suggest considering fsleep() for short msleep calls. > fsleep() autoselects the best sleep mechanism based on duration, > making it the preferred choice for sleep operations. Good enough to me. Reviewed-by: Andy Shevchenko ... > - "usleep_range is preferred over udelay; see function description of usleep_range() and udelay().\n" . $herecurr); > + "fsleep() is preferred over others; usleep_range() is preferred over udelay(); see function descriptions of usleep_range(), udelay(), and fsleep().\n" . $herecurr); ^^^ just for the context for the below. ... > - "msleep < 20ms can sleep for up to 20ms; see function description of msleep().\n" . $herecurr); > + "msleep < 20ms can sleep for up to 20ms; consider using fsleep(); see function description of msleep() and fsleep().\n" . $herecurr); I think 'descriptions' should be plural here as well. -- With Best Regards, Andy Shevchenko