From: Brian Masney <bmasney@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v2 1/3] clk: x86: lpss-atom: Use predefined constants from units.h
Date: Wed, 25 Feb 2026 17:33:10 -0500 [thread overview]
Message-ID: <aZ94prCjOkqLrLdZ@redhat.com> (raw)
In-Reply-To: <20260224121159.3503754-2-andriy.shevchenko@linux.intel.com>
On Tue, Feb 24, 2026 at 01:09:20PM +0100, Andy Shevchenko wrote:
> Use predefined constants from units.h to make code robust against typos
> like how many zeros to put.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
next prev parent reply other threads:[~2026-02-25 22:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 12:09 [PATCH v2 0/3] clk: x86: lpss-atom: A couple of cleanups and a feature Andy Shevchenko
2026-02-24 12:09 ` [PATCH v2 1/3] clk: x86: lpss-atom: Use predefined constants from units.h Andy Shevchenko
2026-02-25 22:33 ` Brian Masney [this message]
2026-02-24 12:09 ` [PATCH v2 2/3] clk: x86: lpss-atom: Use temporary variable for struct device Andy Shevchenko
2026-02-25 22:33 ` Brian Masney
2026-02-24 12:09 ` [PATCH v2 3/3] clk: x86: lpss-atom: Read frequency from the property Andy Shevchenko
2026-02-25 22:33 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ94prCjOkqLrLdZ@redhat.com \
--to=bmasney@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.