From: Brian Masney <bmasney@redhat.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: hisilicon: reset: Use kzalloc instead of kmalloc
Date: Wed, 25 Feb 2026 17:39:28 -0500 [thread overview]
Message-ID: <aZ96IGrGxz8Opka2@redhat.com> (raw)
In-Reply-To: <20260224021912.54365-1-shawnguo@kernel.org>
On Tue, Feb 24, 2026 at 10:19:12AM +0800, Shawn Guo wrote:
> With commit c721f189e89c ("reset: Instantiate reset GPIO controller for
> shared reset-gpios") in place, the call sequence hisi_reset_init() ->
> reset_controller_register() starts failing on Hi3798CV200 Poplar platform,
> due to the new check added by the commit above.
>
> if (rcdev->of_node && rcdev->of_args)
> return -EINVAL;
>
> The failure is caused by that hisi_reset_init() allocates memory for rcdev
> without zeroing it out. Fix the issue by using kzalloc instead of
> kmalloc for memory allocation.
>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Reviewed-by: Brian Masney <bmasney@redhat.com>
next prev parent reply other threads:[~2026-02-25 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 2:19 [PATCH] clk: hisilicon: reset: Use kzalloc instead of kmalloc Shawn Guo
2026-02-25 22:39 ` Brian Masney [this message]
2026-02-26 8:33 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ96IGrGxz8Opka2@redhat.com \
--to=bmasney@redhat.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.