Re: [PATCH v2 5/5] regcache: Amend printf() specifiers when printing registers

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, Feb 25, 2026 at 09:24:36PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 25, 2026 at 07:15:18PM +0000, Mark Brown wrote:
> > On Wed, Feb 25, 2026 at 05:15:59PM +0100, Andy Shevchenko wrote:

...

> > > -	dev_dbg(map->dev, "Writing %zu bytes for %d registers from 0x%x-0x%x\n",
> > > +	dev_dbg(map->dev, "Writing %zu bytes for %d registers from %#x-%#x\n",
> > >  		count * val_bytes, count, base, cur - map->reg_stride);
> > 
> > I'm really not convinced this is helping legibility.
> 
> You mean the only this hunk, or the entire patch?
> 
> If the former, I have no strong opinion, can drop it as 0x%x is (almost)
> an equivalent to %#x. For the %d --> %x I think it needs to be applied as

> it makes harder to debug and follow when some of the messages use register

Under 'it' I meant here the decimal printing versus hexadecimal.

> printed in decimal.

-- 
With Best Regards,
Andy Shevchenko