From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BCD2E81A28 for ; Mon, 16 Feb 2026 14:06:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vrzFF-0002Kh-N5; Mon, 16 Feb 2026 09:06:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vrwhT-00070E-4y; Mon, 16 Feb 2026 06:23:39 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vrwhQ-0001af-IR; Mon, 16 Feb 2026 06:23:34 -0500 Received: from example.com (unknown [167.220.208.72]) by linux.microsoft.com (Postfix) with ESMTPSA id EEE2A20B7165; Mon, 16 Feb 2026 03:23:26 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EEE2A20B7165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1771241009; bh=Eg6doklOkSXqW2yC+S2T+PMcUCpBSTb8BOur3PB01A0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r5xuJmPgBBCvgs+BuANFv0f6AKf1Jkt4Up8mrrfwFHFQqLuXmNct8URVwqkt1FUwJ 3OeD/iZcYpgs79iM9OmAhQ1xw8q74qX6MaGYhEYUCFzBDdsXHLsHatUlCE2XOXKJVZ rSqWytTOqxly/liO9tXm3lAU0qltyYsLrsXtSUV4= Date: Mon, 16 Feb 2026 12:23:25 +0100 From: Magnus Kulke To: Mohamed Mediouni Cc: qemu-devel@nongnu.org, Phil Dennis-Jordan , Bernhard Beschow , Cameron Esfahani , qemu-arm@nongnu.org, Peter Maydell , Roman Bolshakov , Paolo Bonzini , Pedro Barbuda , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Wei Liu , Zhao Liu Subject: Re: [PATCH v3 03/14] target/i386/emulate/x86_decode: Actually use stream in decode_instruction_stream() Message-ID: References: <20260215052225.22513-1-mohamed@unpredictable.fr> <20260215052225.22513-4-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260215052225.22513-4-mohamed@unpredictable.fr> Received-SPF: pass client-ip=13.77.154.182; envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 16 Feb 2026 09:06:35 -0500 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org > Fixes: 1e25327b244a ("target/i386/emulate: Allow instruction decoding from stream") > cc: qemu-stable > Signed-off-by: Bernhard Beschow > Reviewed-by: Mohamed Mediouni > --- > target/i386/emulate/x86_decode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/emulate/x86_decode.c b/target/i386/emulate/x86_decode.c > index 6ad03b71b0..7bbcd2a9a2 100644 > --- a/target/i386/emulate/x86_decode.c > +++ b/target/i386/emulate/x86_decode.c > @@ -2088,8 +2088,6 @@ static void decode_opcodes(CPUX86State *env, struct x86_decode *decode) > > static uint32_t decode_opcode(CPUX86State *env, struct x86_decode *decode) > { > - memset(decode, 0, sizeof(*decode)); > - > decode_prefix(env, decode); > set_addressing_size(env, decode); > set_operand_size(env, decode); > @@ -2101,6 +2099,8 @@ static uint32_t decode_opcode(CPUX86State *env, struct x86_decode *decode) > > uint32_t decode_instruction(CPUX86State *env, struct x86_decode *decode) > { > + memset(decode, 0, sizeof(*decode)); > + > return decode_opcode(env, decode); > } > > -- > 2.50.1 (Apple Git-155) Tested-by: Magnus Kulke makes sense, thx.