From: Lukas Wunner <lukas@wunner.de>
To: Aksh Garg <a-garg7@ti.com>
Cc: linux-pci@vger.kernel.org, maz@kernel.org, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org,
bhelgaas@google.com, cassel@kernel.org,
linux-kernel@vger.kernel.org, s-vadapalli@ti.com,
danishanwar@ti.com
Subject: Re: [PATCH] PCI: Add PCI_RID_MASK macro
Date: Mon, 16 Feb 2026 14:09:18 +0100 [thread overview]
Message-ID: <aZMW_giP0KjM5kpv@wunner.de> (raw)
In-Reply-To: <20260216120600.479738-1-a-garg7@ti.com>
On Mon, Feb 16, 2026 at 05:36:00PM +0530, Aksh Garg wrote:
> +++ b/include/linux/pci.h
> @@ -71,6 +71,7 @@
> #define PCI_DEVID(bus, devfn) ((((u16)(bus)) << 8) | (devfn))
> /* return bus from PCI devid = ((u16)bus_number) << 8) | devfn */
> #define PCI_BUS_NUM(x) (((x) >> 8) & 0xff)
> +#define PCI_RID_MASK 0xffff
Why not instead introduce
#define PCI_RID(x) ((x) & 0xffff)
to go alongside PCI_SLOT() & friends?
Thanks,
Lukas
next prev parent reply other threads:[~2026-02-16 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 12:06 [PATCH] PCI: Add PCI_RID_MASK macro Aksh Garg
2026-02-16 12:14 ` Siddharth Vadapalli
2026-02-16 13:09 ` Lukas Wunner [this message]
2026-02-16 13:26 ` Marc Zyngier
2026-02-17 7:52 ` Aksh Garg
2026-02-17 8:51 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZMW_giP0KjM5kpv@wunner.de \
--to=lukas@wunner.de \
--cc=a-garg7@ti.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=danishanwar@ti.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.