From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 525AEE6815F for ; Tue, 17 Feb 2026 10:06:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsHxg-0002bM-37; Tue, 17 Feb 2026 05:05:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsHxa-0002b6-Gk for qemu-devel@nongnu.org; Tue, 17 Feb 2026 05:05:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsHxY-00029K-NC for qemu-devel@nongnu.org; Tue, 17 Feb 2026 05:05:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771322731; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=h+MgShP5u0txUdposkA5ifeCBlpXilBkSRU64ufSEQg=; b=KguFwEGm2j1Orv6EO6MytGg1hpTpHHlYyMBLe37jowsdBmd7290KGnkZD6VfmKCaH1GDqp ttuRT51JmFAy38TB+w+6qWFsl7zC/RoKfe6KnvLwVuD4Rs8ft1mVaRxHWjyYWMrSLhfjCl WXI7D0LWtz9bpD+RJIFh6jwsTXYrWVE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-kJ5n8R2KMhuM6lta3Z2awA-1; Tue, 17 Feb 2026 05:05:26 -0500 X-MC-Unique: kJ5n8R2KMhuM6lta3Z2awA-1 X-Mimecast-MFC-AGG-ID: kJ5n8R2KMhuM6lta3Z2awA_1771322725 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 437FD1955BC4; Tue, 17 Feb 2026 10:05:25 +0000 (UTC) Received: from redhat.com (unknown [10.45.226.181]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2EA211800370; Tue, 17 Feb 2026 10:05:19 +0000 (UTC) Date: Tue, 17 Feb 2026 10:05:15 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: Sergei Heifetz , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= , Eric Blake , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Markus Armbruster , Fabiano Rosas , Paolo Bonzini , Thomas Huth , Gerd Hoffmann , Laurent Vivier Subject: Re: [PATCH 1/8] audio: add `audio` build option for meson and Kconfig Message-ID: References: <20260217052740.114117-1-heifetz@yandex-team.com> <20260217052740.114117-2-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Feb 17, 2026 at 09:31:20AM +0000, Peter Maydell wrote: > On Tue, 17 Feb 2026 at 05:29, Sergei Heifetz wrote: > > > > This patch adds the `audio` option to meson_options.txt. It is > > propagated into Kconfig as AUDIO. It is enabled by default. > > The corresponding `--disable-audio` and `--enable-audio` options > > for `configure` are also added. > > > > For now, this option does nothing. In subsequent patches, it will > > gradually disable audio in different places. The final goal is to stop > > building sources from `audio/` and `hw/audio/` and other audio-related > > files (except for some stubs). Note that this intent is different from > > `-audio none`, which mutes audio but still compiles the audio subsystem. > > Not building audio/ code makes sense, but do we really want to > stop building hw/audio code ? That's the guest facing audio > devices, and if for instance a machine type has an embedded > sound device that would require us to stop compiling that > machine. I think it would be very confusing for users if > --disable-audio meant "we will silently not build half the > Arm boards that have a pl041 in them". > > Maybe it would be better if "--disable-audio" meant "don't build > the audio backends, and everything behaves as if the user > passed -audio none" ? Don't we already have the ability to disable individual audio backends ? Each of them relies on a different 3rd party library that we have to check for, with none of them being mandatory. I feel like we shouldn't have a "--disable-audio" at all. For backends we always go for having ways to disable individual dependencies, and for frontends we provide Kconfig for fine tuning what's enabled for a given target. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|