From: "Günther Noack" <gnoack@google.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: linux-security-module@vger.kernel.org, Jann Horn <jannh@google.com>
Subject: Re: [PATCH v2 1/2] landlock: Fully release unused TSYNC work entries
Date: Tue, 17 Feb 2026 17:35:31 +0100 [thread overview]
Message-ID: <aZSY06XckK9HvYlS@google.com> (raw)
In-Reply-To: <20260217.cheoghae8Ahh@digikod.net>
On Tue, Feb 17, 2026 at 02:52:46PM +0100, Mickaël Salaün wrote:
> On Tue, Feb 17, 2026 at 01:41:11PM +0100, Günther Noack wrote:
> > On Tue, Feb 17, 2026 at 01:23:39PM +0100, Mickaël Salaün wrote:
> > > + memset(ctx, 0, sizeof(*ctx));
> >
> > Minor (and highly optional) remark, this is the same as
> >
> > *ctx = (struct tsync_work){};
>
> What about:
>
> *ctx = (typeof(*ctx)){};
I find that harder to read, because it is less commonly seen and the typeof() is
an indirection that makes me think as a reader. But at this point, this is only
a vague opinion and I don't feel strongly about it. Please submit either one of
these three options :)
—Günther
prev parent reply other threads:[~2026-02-17 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 12:23 [PATCH v2 1/2] landlock: Fully release unused TSYNC work entries Mickaël Salaün
2026-02-17 12:23 ` [PATCH v2 2/2] landlock: Improve TSYNC types Mickaël Salaün
2026-02-17 12:41 ` [PATCH v2 1/2] landlock: Fully release unused TSYNC work entries Günther Noack
2026-02-17 13:52 ` Mickaël Salaün
2026-02-17 16:35 ` Günther Noack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZSY06XckK9HvYlS@google.com \
--to=gnoack@google.com \
--cc=jannh@google.com \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.