All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kiryl Shutsemau <kas@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Wenchao Hao <haowenchao22@gmail.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	 "Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	 Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	 Michal Hocko <mhocko@suse.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Add AnonZero accounting for zero-filled anonymous pages
Date: Tue, 17 Feb 2026 21:53:53 +0000	[thread overview]
Message-ID: <aZTgnAkXecRPUGxs@thinkstation> (raw)
In-Reply-To: <419053a2-9784-4051-b73e-5871d3c32be9@kernel.org>

On Tue, Feb 17, 2026 at 09:29:02PM +0100, David Hildenbrand (Arm) wrote:
> On 2/17/26 16:22, Wenchao Hao wrote:
> > On Sat, Feb 14, 2026 at 4:45 PM Wenchao Hao <haowenchao22@gmail.com> wrote:
> > > 
> > > Add kernel command line option "count_zero_page" to track anonymous pages
> > > have been allocated and mapped to userspace but zero-filled.
> > > 
> > > This feature is mainly used to debug large folio mechanism, which
> > > pre-allocates and map more pages than actually needed, leading to memory
> > > waste from unaccessed pages.
> > > 
> > > Export the result in /proc/pid/smaps as "AnonZero" field.
> > > 
> > > Link: https://lore.kernel.org/linux-mm/20260210043456.2137482-1-haowenchao22@gmail.com/
> > 
> > Sorry for the late reply. We are now on Chinese New Year holiday, so...
> > 
> > The original goal of this patch is to measure memory waste from anonymous
> > THPs - pages pre-allocated on fault but never accessed.
> > 
> > On memory-sensitive devices like mobile phones, this helps us make better
> > decisions about when and how to enable THP. I think this is useful for
> > guiding THP policies, even as a debugging feature.
> > 
> > Let me summarize the discussion so far:
> > - Matthew Wilcox questioned the value and raised concerns fork but haven't
> >    exec path
> > - Michal Hocko criticized the inefficiency of scanning zero-filled pages.
> > - Kiryl Shutsemau prefers a system-call-based interface.
> > - David Hildenbrand acknowledged the value and suggested implementation
> >    improvements.
> > Please correct me if I missed or misrepresented anything.
> > 
> > I suggest we first agree whether this functionality is useful for upstream,
> > before discussing implementation details.
> > 
> > Reasons why this should go upstream from me:
> > 
> > - Anonymous THP can introduce real memory waste, but we currently have no
> >    good way to measure it.
> > - With accurate metrics, we can make better THP policy: disable for
> >    low-utilization cases, or early-unmap to relieve memory pressure and so
> >    on. This is especially valuable for mobile/embedded devices.
> > 
> > Possible implementations:
> > 
> > 1. A new smaps counter (default-off) to count zero-filled pages.
> > 2. A new madvise command like MADV_GET_ZEROPAGE
> > 3. A dedicated system call
> 
> I understand Kiyls point about smaps providing too much information users
> might not be interested in already. So sorting that out might provide a real
> benefit to other users that are only interested in specific stats (e.g.,
> Rss).

You can also limit the range of virtual address space you want to look
at.

> Providing a system call where one can specify/filter in theory sounds like a
> good idea. A syscall implies that one has to write a tool to obtain these
> metrics.
> 
> The nice thing about smaps/smaps_rollup is that it can be easily consumed on
> any system while debugging.
> 
> I wonder if there could be a way to achieve something similar with a file.
> Likely not, but maybe someone reading along can surprise me :)

I guess you can open a file write to it what you want to get and then
read. It is awkward from shell to keep file descriptor around, but doable.

> Otherwise we'd have to go with a tool.

A tool might be more ergonomic.

To minimize friction, it would be nice to put the tool into util-linux
(or whatever trendy Rust-rewrite called), so it would find its way to
every machine. Eventually.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov


  reply	other threads:[~2026-02-17 21:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14  8:45 [PATCH] mm: Add AnonZero accounting for zero-filled anonymous pages Wenchao Hao
2026-02-16 11:34 ` Kiryl Shutsemau
2026-02-16 11:45   ` David Hildenbrand (Arm)
2026-02-16 11:58     ` Kiryl Shutsemau
2026-02-16 12:19       ` David Hildenbrand (Arm)
2026-02-16 15:59       ` Wenchao Hao
2026-02-16 16:42         ` Michal Hocko
2026-02-16 16:56           ` David Hildenbrand (Arm)
2026-02-16 17:10             ` Michal Hocko
2026-02-16 17:17               ` David Hildenbrand (Arm)
2026-02-16 16:54         ` Kiryl Shutsemau
2026-02-16 17:01           ` Matthew Wilcox
2026-02-16 17:10             ` David Hildenbrand (Arm)
2026-02-16 17:18             ` Kiryl Shutsemau
2026-02-16 12:15 ` David Hildenbrand (Arm)
2026-02-16 15:10   ` Wenchao Hao
2026-02-16 15:18     ` David Hildenbrand (Arm)
2026-02-16 14:22 ` Matthew Wilcox
2026-02-16 15:55   ` Wenchao Hao
2026-02-16 17:03 ` Matthew Wilcox
2026-02-17 15:22 ` Wenchao Hao
2026-02-17 20:29   ` David Hildenbrand (Arm)
2026-02-17 21:53     ` Kiryl Shutsemau [this message]
2026-02-19  2:11       ` Wenchao Hao
2026-02-18  7:52   ` Michal Hocko
2026-02-19  2:47     ` Wenchao Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZTgnAkXecRPUGxs@thinkstation \
    --to=kas@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=haowenchao22@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.