From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>
Subject: Re: [PATCH v4 1/1] regmap: Synchronize cache for the page selector
Date: Wed, 18 Feb 2026 11:57:57 +0200 [thread overview]
Message-ID: <aZWNJXRcurzi39U4@smile.fi.intel.com> (raw)
In-Reply-To: <ea73c205-ded8-440a-abcc-6c4138f5512b@samsung.com>
On Wed, Feb 18, 2026 at 09:30:41AM +0100, Marek Szyprowski wrote:
> On 18.02.2026 08:46, Andy Shevchenko wrote:
> > If the selector register is represented in each page, its value
> > according to the debugfs is stale because it gets synchronized
> > only after the real page switch happens. Hence the regmap cache
> > initialisation from the HW inherits outdated data in the selector
> > register.
> >
> > Synchronize cache for the page selector just in time.
> >
> > Before (offset followed by hexdump, the first byte is selector):
> >
> > // Real registers
> > 18: 05 ff 00 00 ff 0f 00 00 f0 00 00 00
> > ...
> > // Virtual (per port)
> > 40: 05 ff 00 00 e0 e0 00 00 00 00 00 1f
> > 50: 00 ff 00 00 e0 e0 00 00 00 00 00 1f
> > 60: 01 ff 00 00 ff ff 00 00 00 00 00 00
> > 70: 02 ff 00 00 cf f3 00 00 00 00 00 0c
> > 80: 03 ff 00 00 00 00 00 00 00 00 00 ff
> > 90: 04 ff 00 00 ff 0f 00 00 f0 00 00 00
> >
> > After:
> >
> > // Real registers
> > 18: 05 ff 00 00 ff 0f 00 00 f0 00 00 00
> > ...
> > // Virtual (per port)
> > 40: 00 ff 00 00 e0 e0 00 00 00 00 00 1f
> > 50: 01 ff 00 00 e0 e0 00 00 00 00 00 1f
> > 60: 02 ff 00 00 ff ff 00 00 00 00 00 00
> > 70: 03 ff 00 00 cf f3 00 00 00 00 00 0c
> > 80: 04 ff 00 00 00 00 00 00 00 00 00 ff
> > 90: 05 ff 00 00 ff 0f 00 00 f0 00 00 00
> >
> > Fixes: 6863ca622759 ("regmap: Add support for register indirect addressing.")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v4: reworked the approach completely
> >
> > Marek, Dmitry,
> > Please, test on your HW to be sure this will have no side effects
> > in your case with LT9611.
>
> It looks that it ends in infinite recurrent calls after this patch:
Thank you for the prompt testing! Can you also _add_ the patch on top from
https://lore.kernel.org/all/Z4ppo8wV3nicOfAQ@smile.fi.intel.com/ ?
> Insufficient stack space to handle exception!
> ESR: 0x0000000096000047 -- DABT (current EL)
> FAR: 0xffff8000859bffe0
> Task stack: [0xffff8000859c0000..0xffff8000859c4000]
> IRQ stack: [0xffff800080030000..0xffff800080034000]
> Overflow stack: [0xffff0001fef36140..0xffff0001fef37140]
> CPU: 6 UID: 0 PID: 341 Comm: (udev-worker) Not tainted
> 6.19.0-next-20260217+ #12215 PREEMPT
> Hardware name: Qualcomm Technologies, Inc. Robotics RB5 (DT)
> pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> pc : _regmap_select_page+0x4/0x120
> lr : _regmap_raw_read+0x240/0x340
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-18 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260218074952eucas1p2fb09d58aec2392e8f21f4b66a6163230@eucas1p2.samsung.com>
2026-02-18 7:46 ` [PATCH v4 1/1] regmap: Synchronize cache for the page selector Andy Shevchenko
2026-02-18 8:30 ` Marek Szyprowski
2026-02-18 9:57 ` Andy Shevchenko [this message]
2026-02-18 10:56 ` Marek Szyprowski
2026-02-18 11:30 ` Andy Shevchenko
[not found] ` <c7913aea-3b20-48c6-b555-4c43d8e28422@samsung.com>
2026-02-18 10:59 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZWNJXRcurzi39U4@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.