From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Joaquim Rocha via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Joaquim Rocha <me@joaquimrocha.com>,
Joaquim Rocha <joaquim@amutable.com>
Subject: Re: [PATCH] apply: strip ./ prefix from --directory argument
Date: Wed, 18 Feb 2026 15:14:46 +0100 [thread overview]
Message-ID: <aZXJVtgRYQAnxNnE@pks.im> (raw)
In-Reply-To: <xmqqzf579kuc.fsf@gitster.g>
On Tue, Feb 17, 2026 at 12:27:39PM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > While this change here fixes your observed issues, the next person might
> > run into a totally different one. So more generally, I think what we'd
> > rather want to do is to fully normalize the path. How about this
> > instead:
>
> Sorry, but I am confused. Why isn't "don't do it then" a good
> answer for a case like this?
I guess that's fair, but especially with command line completion it
might be easy to arrive at such paths. That may or may not be a good
argument, I'm not sure myself.
Patrick
next prev parent reply other threads:[~2026-02-18 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 17:08 [PATCH] apply: strip ./ prefix from --directory argument Joaquim Rocha via GitGitGadget
2026-02-17 8:06 ` Patrick Steinhardt
2026-02-17 20:27 ` Junio C Hamano
2026-02-18 14:14 ` Patrick Steinhardt [this message]
2026-02-18 14:40 ` Joaquim Rocha
2026-02-18 0:15 ` [PATCH v2] apply: normalize path in " Joaquim Rocha via GitGitGadget
2026-02-20 20:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZXJVtgRYQAnxNnE@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=joaquim@amutable.com \
--cc=me@joaquimrocha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.