From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 2/4] iio: adc: ti-ads7950: do not clobber gpio state in ti_ads7950_get()
Date: Thu, 19 Feb 2026 09:55:59 +0200 [thread overview]
Message-ID: <aZbCDz8CdW5f_3y3@smile.fi.intel.com> (raw)
In-Reply-To: <20260219022929.3558081-3-dmitry.torokhov@gmail.com>
On Wed, Feb 18, 2026 at 06:29:26PM -0800, Dmitry Torokhov wrote:
> GPIO state was inadvertently overwritten by the result of sip_sync,
sip?
> reuniting in ti_ads7950_get() only returning 0 as gpio state (or error).
GPIO
> Fix this by introducing a separate variable to hold the state.
...
> - int ret;
> + int ret = 0;
This kind of assignment is harder to maintain, because it leaves a room for
subtle mistakes (when it's reused by a newly injected code, quite similar,
actually, to what this change tries to address). Please, decouple definition
and assignment.
> + bool state;
Not sure about this (yes, I know it was suggested). I would leave it still
the same type as one that is returned by the function or a compatible one
that is the same as st->* (if the used ones are all of the same type).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-19 7:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 2:29 [PATCH v2 0/4] ti-ads7950: fix gpio handling and facelift Dmitry Torokhov
2026-02-19 2:29 ` [PATCH v2 1/4] iio: adc: ti-ads7950: normalize return value of gpio_get Dmitry Torokhov
2026-02-19 7:52 ` Andy Shevchenko
2026-02-19 9:17 ` Bartosz Golaszewski
2026-02-19 18:25 ` Linus Walleij
2026-02-22 14:03 ` Jonathan Cameron
2026-02-22 21:22 ` Dmitry Torokhov
2026-02-19 2:29 ` [PATCH v2 2/4] iio: adc: ti-ads7950: do not clobber gpio state in ti_ads7950_get() Dmitry Torokhov
2026-02-19 7:55 ` Andy Shevchenko [this message]
2026-02-21 17:21 ` David Lechner
2026-02-19 2:29 ` [PATCH v2 3/4] iio: adc: ti-ads7950: switch to using guard() notation Dmitry Torokhov
2026-02-19 7:51 ` Andy Shevchenko
2026-02-21 17:20 ` David Lechner
2026-02-22 21:31 ` Dmitry Torokhov
2026-02-23 16:35 ` David Lechner
2026-02-21 17:34 ` David Lechner
2026-02-22 21:37 ` Dmitry Torokhov
2026-02-23 16:31 ` David Lechner
2026-02-19 2:29 ` [PATCH v2 4/4] iio: adc: ti-ads7950: complete conversion to using managed resources Dmitry Torokhov
2026-02-19 7:59 ` Andy Shevchenko
2026-02-21 0:09 ` Dmitry Torokhov
2026-02-22 19:12 ` Andy Shevchenko
2026-02-23 20:52 ` Jonathan Cameron
2026-02-21 17:43 ` David Lechner
2026-02-22 14:09 ` Jonathan Cameron
2026-02-22 21:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZbCDz8CdW5f_3y3@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=dlechner@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.