From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f195.google.com (mail-dy1-f195.google.com [74.125.82.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4607134CFBB for ; Thu, 19 Feb 2026 16:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771520390; cv=none; b=MH1HK4WmCFgB2i7whFBfd3UALjbXT9qSEwQ7hkNT/4A9SiqWxqrwbfWFgrnpWXZ3pH0GOFSNXCmmTo6osY0dgo/5iMJJlWJ4HQJIn+5EeZhJRJq1f9ECHTDaDXTY3CDeTnpbOHDmXMu7gujLnevPtFTU41CLPlHovOWNgWjjPFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771520390; c=relaxed/simple; bh=RtI4mwfwD+P3PGHnYKcB617QTsULwQHjdTQD30kM5yE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SZhQH2r+7vvq4c9SMTDyWmZz6pW6VU77EVKypaD8RTAwFTPMFz2cdeo8q7c2Ufv/OJNAltzzS1PfNSR2kQnN9VhLBrCsi+m45M0Cub7p4iDZSc9dwtIlUlN2f/uutxk2LFV20SyT1WMRxh7fWs2dpf7YxGWEAGRPbq/FEtHKAs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CSs/0xO+; arc=none smtp.client-ip=74.125.82.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CSs/0xO+" Received: by mail-dy1-f195.google.com with SMTP id 5a478bee46e88-2bab70f8c8aso1021793eec.1 for ; Thu, 19 Feb 2026 08:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771520388; x=1772125188; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2gvE0EmLNuGUVVdF/D3DSAFzHLiwuA/iBJjerEqpTAE=; b=CSs/0xO+xNcfj07lRrvq8rBQemimXV5BIrmNEUj99nlHY7+LPM89d70fkX54tbPkq0 Z3NMTjHTXEBtfNvXXp66tZVCg9akCgH6n00Sa6fPYALxUfKPBxsTuBh5IFV8WEjXt9N2 S82o5DBuFdAlAXMUg96YnOYrMTjNovNOEcT3EZI9oywseWqhGz9zwtYe7V6MnY88vb8i bRUowXZr7vXMobh5YfR43S4ndJgjwOeA3Dmg3oNvLyuZsuTW8i0YEHBleV4evMmyR85g qBLmHg5UCXxG/wpTx2xMq1eh43nWYOFCRWst2sY4q1KWKfODwHaXTTA9/fKUA64D3QAk wgYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771520388; x=1772125188; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2gvE0EmLNuGUVVdF/D3DSAFzHLiwuA/iBJjerEqpTAE=; b=rgrzJwscRdhCwVS3mZmJ0BjRDde0GAY7TL3Mm9lW69eNdTiRJRYd1lAXzFaktzMAZw UBw1T624cY04AMl2UJmrnTEp/UP7aAm5U6llE/LAs1AQTxAUV5xnW79W66DtVwrAoie8 EIiqtBxdN1cF1JfeVJog/AWcf5GWYVoh1/iA/BWmGwfkRQlS5LwUcKI0Py4GQMTMfKCy txoTPlJqquWKa7DGMZoLcSxMDxIbUYxTnmVqJlWOZuVzvYIebZ8+q3qJsKPcUQBWdDAB MZJdQUVa5nzqdrwYYG/cOnRhUbxF342+AxRyCQ+yuVFN/f0lWhrwJce/ZqF0XXC0FUvU WO5Q== X-Forwarded-Encrypted: i=1; AJvYcCWnOehaZdeGgNE7xiSogyOZWfP5QhDmSGoiUugfLgKm8gATKfqgAR/pZX9eUeIjKvtWX245kfClcoYU@vger.kernel.org X-Gm-Message-State: AOJu0YzIxwItFKnTeA50rkvrr9ZRyAayM1fWPyhNq9XUXY/FV/S/nk0c XMKrP+Cl1IO5KBHMkmro6MwWnHMUM4nt53nMWXLASOOzh1eDH2QnQhgR X-Gm-Gg: AZuq6aJskiRULHGBU3/TfTbvesBHmn+QINomxuvFHj1xJIuxR3ImDHSkeD3n/1iOGtW l+MYOEIt6VgRWHLpl0CGhCCtm+E+lHcHYPcmyRy55yCdklQfc5QIMatj/iAmchmmCMwgsyR17wh +S6CVqgjLaWw4zZs+iIPN5H6kRedcAhj/QQgekSOYOZEgqSHNIU1IMsoPZpYjB1UuyqI4AB0S14 3wRlhGSJ+bzB3WA8nUf6R/WXDn0mzSs9DDWegdW+udTH5Dcjm/CLH/P4ROfMgToMQ0EJnvpmn+v gl9UZYkSpUw5YxDtpAPblWUPaAEvZhvUR3XDCB9MNBi2NcoAqb1Pi+fh8yX1o87UqQC3VoWtxTJ GVLy1WsJ/KbLraTncy2eTSMhhEvZHzPSxb93dKE4uX8KkZPliCrF83kRt+P+u/i85KKuoNMPLR8 3MjTFpmfqAQWMuejv/acvFT2Ld9I5QeivuOxxuQEMhtVsZZsRIsbtCQC9iN3nAz/Rj X-Received: by 2002:a05:693c:3108:b0:2ba:6854:8d4d with SMTP id 5a478bee46e88-2bd501701e4mr2840676eec.20.1771520388134; Thu, 19 Feb 2026 08:59:48 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:9c24:8181:603e:7ad7]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bacb658fc4sm24932889eec.22.2026.02.19.08.59.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 08:59:47 -0800 (PST) Date: Thu, 19 Feb 2026 08:59:45 -0800 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] gpiolib: normalize the return value of gc->get() on behalf of buggy drivers Message-ID: References: <20260219-gpiolib-set-normalize-v2-1-f84630e45796@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260219-gpiolib-set-normalize-v2-1-f84630e45796@oss.qualcomm.com> On Thu, Feb 19, 2026 at 10:51:33AM +0100, Bartosz Golaszewski wrote: > Commit 86ef402d805d ("gpiolib: sanitize the return value of > gpio_chip::get()") started checking the return value of the .get() > callback in struct gpio_chip. Now - almost a year later - it turns out > that there are quite a few drivers in tree that can break with this > change. Partially revert it: normalize the return value in GPIO core but > also emit a warning. > > Cc: stable@vger.kernel.org > Fixes: 86ef402d805d ("gpiolib: sanitize the return value of gpio_chip::get()") > Reported-by: Dmitry Torokhov > Closes: https://lore.kernel.org/all/aZSkqGTqMp_57qC7@google.com/ > Signed-off-by: Bartosz Golaszewski > --- > Changes in v2: > - it's gpio_chip::get() that needs normalizing, not gpio_chip::set() > - Link to v1: https://patch.msgid.link/20260219-gpiolib-set-normalize-v1-1-f0d53a009db4@oss.qualcomm.com > --- > drivers/gpio/gpiolib.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index c52200eaaaff82b12f22dd1ee8459bdd8ec10d81..c9cd751e7de2307fc5994eb682c53f2b3ce39233 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -3268,8 +3268,12 @@ static int gpiochip_get(struct gpio_chip *gc, unsigned int offset) > > /* Make sure this is called after checking for gc->get(). */ > ret = gc->get(gc, offset); > - if (ret > 1) > - ret = -EBADE; > + if (ret > 1) { > + gpiochip_warn(gc, > + "invalid return value from gc->get(): %d, consider fixing the driver\n", > + ret); > + ret = !!ret; > + } > > return ret; > } Thank you Bartosz. I guess this could turn out to be pretty noisy but maybe that will make users report it faster ;) Reviewed-by: Dmitry Torokhov -- Dmitry