All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Stewart Hildebrand <stewart.hildebrand@amd.com>
Subject: Re: [PATCH v4 3/5] vPCI: move vpci_init_capabilities() to a separate file
Date: Fri, 20 Feb 2026 09:48:47 +0100	[thread overview]
Message-ID: <aZgf72lwLryKCb6L@macbook.local> (raw)
In-Reply-To: <c90890f0-2e6a-43d9-84f9-b0ea19a11d3d@suse.com>

On Tue, Feb 10, 2026 at 11:54:18AM +0100, Jan Beulich wrote:
> Let's keep capability handling together. Start with moving
> vpci_init_capabilities() and its helpers, plus splitting out of its
> cleanup counterpart.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> vpci_get_register(), while now only used by cap.c, didn't look like it
> would want moving there.

I think it's best to keep the vpci_{get,add,remove}_register{,s}()
functions in the same file.

Thanks, Roger.


  parent reply	other threads:[~2026-02-20  8:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 10:51 [PATCH v4 0/5] (v)PCI: extended capability handling Jan Beulich
2026-02-10 10:52 ` [PATCH v4 1/5] x86/PCI: avoid re-evaluation of extended config space accessibility Jan Beulich
2026-02-10 15:59   ` Stewart Hildebrand
2026-02-10 10:53 ` [PATCH v4 2/5] vPCI: introduce private header Jan Beulich
2026-02-17 22:04   ` Stewart Hildebrand
2026-02-18  8:52     ` Jan Beulich
2026-02-18 21:58   ` Stewart Hildebrand
2026-02-19  6:26     ` Jan Beulich
2026-02-10 10:54 ` [PATCH v4 3/5] vPCI: move vpci_init_capabilities() to a separate file Jan Beulich
2026-02-18 15:50   ` Stewart Hildebrand
2026-02-20  8:48   ` Roger Pau Monné [this message]
2026-02-10 10:54 ` [PATCH v4 4/5] vPCI: move capability-list init Jan Beulich
2026-02-18 20:54   ` Stewart Hildebrand
2026-02-20  8:59   ` Roger Pau Monné
2026-02-10 10:55 ` [PATCH v4 5/5] vPCI: re-init extended-capabilities when MMCFG availability changed Jan Beulich
2026-02-19 22:21   ` Stewart Hildebrand
2026-02-20  7:13     ` Jan Beulich
2026-02-20  9:08       ` Roger Pau Monné
2026-02-20  9:28   ` Roger Pau Monné
2026-02-20 10:20     ` Jan Beulich
2026-02-20 10:53       ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZgf72lwLryKCb6L@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=stewart.hildebrand@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.