From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] iio: core: Simplify IIO core managed APIs
Date: Fri, 20 Feb 2026 15:29:31 +0200 [thread overview]
Message-ID: <aZhhuxD9YWefCAuY@smile.fi.intel.com> (raw)
In-Reply-To: <20260220121450.74586f44@jic23-huawei>
On Fri, Feb 20, 2026 at 12:14:50PM +0000, Jonathan Cameron wrote:
> On Fri, 20 Feb 2026 12:27:40 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Fri, Feb 20, 2026 at 12:18 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > > On Mon, 16 Feb 2026 09:14:12 +0100
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
...
> > > This had me briefly confused as I failed to notice it was static
> > > (no idea why I gave such a simple internal function kernel-doc!)
> > >
> > > However that brings the obvious follow up question. Given your
> > > simplification does having a helper make sense given only a single caller?
> > >
> > > Let's just squash it and have the two calls inline + some resulting docs
> > > updates to get rid of the references to this function.
> >
> > Do you want to have this change inside the proposed patch? Or in a
> > separate (pre/post) one?
> Same patch would be fine I think. It's small and coupled to the code
> getting simpler because of the main change here. Seems like a pointless
> dance to refactor same code twice.
v2 has just been sent.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-20 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 8:14 [PATCH v1 1/1] iio: core: Simplify IIO core managed APIs Andy Shevchenko
2026-02-16 14:31 ` Nuno Sá
2026-02-17 7:45 ` Andy Shevchenko
2026-02-17 13:29 ` Nuno Sá
2026-02-17 13:32 ` Andy Shevchenko
2026-02-20 10:09 ` Nuno Sá
2026-02-20 10:18 ` Jonathan Cameron
2026-02-20 10:27 ` Andy Shevchenko
2026-02-20 12:14 ` Jonathan Cameron
2026-02-20 13:29 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZhhuxD9YWefCAuY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.