All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Koichiro Den <den@valinux.co.jp>,
	mani@kernel.org, kwilczynski@kernel.org, kishon@kernel.org,
	bhelgaas@google.com, corbet@lwn.net, jingoohan1@gmail.com,
	lpieralisi@kernel.org, robh@kernel.org, Frank.Li@nxp.com,
	linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] PCI: dwc: ep: Fix BAR update handling with in-place epf_bar reuse
Date: Fri, 20 Feb 2026 17:02:34 +0100	[thread overview]
Message-ID: <aZiFe6Pl-LI0fIVg@ryzen> (raw)
In-Reply-To: <20260219194356.GA3493507@bhelgaas>

On Thu, Feb 19, 2026 at 01:43:56PM -0600, Bjorn Helgaas wrote:
> On Mon, Feb 02, 2026 at 11:54:05PM +0900, Koichiro Den wrote:
> > Hi,
> > 
> > This patch series is a follow-up to a side discussion that started from
> > Niklas' comment at:
> > https://lore.kernel.org/all/aXtrW7viGZfMNZur@ryzen/
> > 
> > This series:
> >   1) Makes BAR Match vs Address Match teardown in DesignWare EP explicit
> >      by returning right after clearing a BAR-match inbound mapping.
> >   2) Fixes the dw_pcie_ep_set_bar() mapping-update path to run
> >      dw_pcie_ep_clear_ib_maps() unconditionally, since the driver cannot
> >      reliably distinguish BAR Match -> BAR Match from Address Match ->
> >      BAR Match transitions when the same epf_bar instance is updated in
> >      place and passed in again.
> > 
> > Base: controller/dwc branch, latest:
> > commit a24149881558 ("PCI: dwc: ep: Add comment explaining controller level
> >                       PTM access in multi PF setup")
> > 
> > Changes since v1:
> >   - Switched from the v1 approach (Y) to the alternative approach (X)
> >     that was proposed earlier in the discussion.
> >     Details of the v1 (Y) vs v2 (X) are described at:
> >     https://lore.kernel.org/all/sextbnbmsur2xjfoun2l4lr5vekmpzae7sx6or2ird44t6ud6d@yprcz43tpq4p/
> >   - Changed the subject.
> > 
> > v1: https://lore.kernel.org/all/20260131133655.218018-1-den@valinux.co.jp/
> > 
> > Thanks,
> > 
> > 
> > Koichiro Den (2):
> >   PCI: dwc: ep: Return after clearing BAR-match inbound mapping
> >   PCI: dwc: ep: Always clear IB maps on BAR update
> > 
> >  drivers/pci/controller/dwc/pcie-designware-ep.c | 15 ++++++++++++---
> >  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> Since this fixes an issue with the new inbound submapping feature
> we merged for v7.0, I put both of these on pci/for-linus for v7.0.

Thank you Bjorn!

If possible, I please consider sending these to Linus as well:
https://patchwork.kernel.org/project/linux-pci/patch/20260210181225.3926165-2-cassel@kernel.org/

The Fixes tag:
Fixes: 8719c64e76bf ("PCI: dwc: ep: Cache MSI outbound iATU mapping")
references a commit that was included in v7.0 merge window, so it would be
nice to have the above fix patch in v7.0.



This is fixing the same problem as 8719c64e76bf ("PCI: dwc: ep: Cache MSI
outbound iATU mapping") fixed for dw_pcie_ep_raise_msi_irq():
https://patchwork.kernel.org/project/linux-pci/patch/20260211175540.105677-2-cassel@kernel.org/

Mani has marked this commit as "Awaiting Upstream", I'm guessing he plans
to queue it for v7.1 ?
If not to much trouble, I think it would be nice to have in v7.0 as well,
so we have both functional dw_pcie_ep_raise_msi_irq() and
dw_pcie_ep_raise_msix_irq() in v7.0.


Kind regards,
Niklas

      parent reply	other threads:[~2026-02-20 16:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 14:54 [PATCH v2 0/2] PCI: dwc: ep: Fix BAR update handling with in-place epf_bar reuse Koichiro Den
2026-02-02 14:54 ` [PATCH v2 1/2] PCI: dwc: ep: Return after clearing BAR-match inbound mapping Koichiro Den
2026-02-02 15:29   ` Niklas Cassel
2026-02-02 14:54 ` [PATCH v2 2/2] PCI: dwc: ep: Always clear IB maps on BAR update Koichiro Den
2026-02-02 15:34   ` Niklas Cassel
2026-02-09  5:40 ` [PATCH v2 0/2] PCI: dwc: ep: Fix BAR update handling with in-place epf_bar reuse Koichiro Den
2026-02-09 11:35   ` Manivannan Sadhasivam
2026-02-09 12:56     ` Koichiro Den
2026-02-19 19:43 ` Bjorn Helgaas
2026-02-20  3:42   ` Koichiro Den
2026-02-20 16:02   ` Niklas Cassel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZiFe6Pl-LI0fIVg@ryzen \
    --to=cassel@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=corbet@lwn.net \
    --cc=den@valinux.co.jp \
    --cc=helgaas@kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.