Re: [PATCH v2 01/23] drm/xe/mtl: Drop pre-prod workarounds Wa_14015795083 & Wa_14014475959

["Vivekanandan, Balasubramani" <balasubramani.vivekanandan@intel.com>]

On 20.02.2026 09:27, Matt Roper wrote:
> Wa_14015795083 and Wa_14014475959 only apply to early steppings of
> Xe_LPG that appeared only in pre-production hardware (in fact
> Wa_14014475959 wasn't supposed to apply to _any_ steppings of version
> 12.71).  Xe1 platforms already aren't officially supported by the Xe
> driver, but pre-production steppings are especially out of scope (and
> 'has_pre_prod_wa' is not set in the device descriptor).  Drop both
> workarounds.
> 
> Bspec: 55420
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_wa.c         | 4 ----
>  drivers/gpu/drm/xe/xe_wa_oob.rules | 3 +--
>  2 files changed, 1 insertion(+), 6 deletions(-)

LGTM,

Reviewed-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>

Regards,
Bala

> 
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 76fa6d510aadb91169170ba35f65390c477a569e..aa5755bcdc04a3ec2569ab9676a9dd95516f1711 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -191,10 +191,6 @@ static const struct xe_rtp_entry_sr gt_was[] = {
>  
>  	/* Xe_LPG */
>  
> -	{ XE_RTP_NAME("14015795083"),
> -	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1270, 1271), GRAPHICS_STEP(A0, B0)),
> -	  XE_RTP_ACTIONS(CLR(MISCCPCTL, DOP_CLOCK_GATE_RENDER_ENABLE))
> -	},
>  	{ XE_RTP_NAME("14018575942"),
>  	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1270, 1274)),
>  	  XE_RTP_ACTIONS(SET(COMP_MOD_CTRL, FORCE_MISS_FTLB))
> diff --git a/drivers/gpu/drm/xe/xe_wa_oob.rules b/drivers/gpu/drm/xe/xe_wa_oob.rules
> index ac08f94f90a142629545c4964ca0fd3f9cad6aa9..cc988f2a18d33365dc09d32f4e85ced01b823877 100644
> --- a/drivers/gpu/drm/xe/xe_wa_oob.rules
> +++ b/drivers/gpu/drm/xe/xe_wa_oob.rules
> @@ -2,8 +2,7 @@
>  16010904313	GRAPHICS_VERSION_RANGE(1200, 1210)
>  18022495364	GRAPHICS_VERSION_RANGE(1200, 1210)
>  22012773006	GRAPHICS_VERSION_RANGE(1200, 1250)
> -14014475959	GRAPHICS_VERSION_RANGE(1270, 1271), GRAPHICS_STEP(A0, B0)
> -		PLATFORM(DG2)
> +14014475959	PLATFORM(DG2)
>  22011391025	PLATFORM(DG2)
>  22012727170	SUBPLATFORM(DG2, G11)
>  22012727685	SUBPLATFORM(DG2, G11)
> 
> -- 
> 2.53.0
>