From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Felix Gu <ustc.gu@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Jorge Marques" <jorge.marques@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad4062: Replace IRQF_ONESHOT with IRQF_NO_THREAD
Date: Mon, 23 Feb 2026 11:01:09 +0200 [thread overview]
Message-ID: <aZwXVZ-eq3OULitA@smile.fi.intel.com> (raw)
In-Reply-To: <20260223-ad4062-v1-1-8ee93ea173a6@gmail.com>
On Mon, Feb 23, 2026 at 02:45:13PM +0800, Felix Gu wrote:
> In ad4062_request_irq(), when request irq for "gp1", the code uses
> IRQF_ONESHOT flag, which is not appropriate for a primary handler
> that does not have a secondary threaded handler.
>
> And since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> in IRQ request and gives a warning if there is no threaded handler.
>
> Since there is no threaded handler, replace devm_request_threaded_irq
> with devm_request_irq, and replace IRQF_ONESHOT with IRQF_NO_THREAD.
>
> Also remove an extraneous semicolon at the end of
> ad4062_write_raw_dispatch().
>
> Found by code review, compile pass.
Wondering if @bigeasy already sent a patch for this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-23 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 6:45 [PATCH] iio: adc: ad4062: Replace IRQF_ONESHOT with IRQF_NO_THREAD Felix Gu
2026-02-23 9:01 ` Andy Shevchenko [this message]
2026-02-24 13:44 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZwXVZ-eq3OULitA@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jorge.marques@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.