Re: [PATCH 3/4] MAKEALL: error out on options placed after the defconfig argument

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Feb 23, 2026 at 12:31:34PM +0100, Ahmad Fatoum wrote:
> getopts stops parsing at the first non-option argument, so options
> like -k after the defconfig name silently end up as positional
> arguments. For bare defconfigs these get misinterpreted as pytest
> options and are silently ignored, leading to a build without the
> intended configuration.
> 
> Detect this by checking for trailing arguments when any positional
> argument is a bare defconfig (not a labgrid .yaml config, where
> extra arguments are intentionally forwarded to pytest).

Can't we use getopt for MAKEALL instead of getopts? getopt just does the
right thing.

Sascha

> 
> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
> Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
> ---
>  MAKEALL | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/MAKEALL b/MAKEALL
> index c36aed625820..dd0b7f8003cc 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -440,6 +440,15 @@ else
>  
>  		configs+=($i)
>  	done
> +	if [ ${#pytest_opts[@]} -gt 0 ]; then
> +		for i in "${configs[@]}"; do
> +			if ! [[ $i =~ .yaml$ ]]; then
> +				echo "error: unexpected arguments after defconfig: ${pytest_opts[*]}" >&2
> +				echo "hint: place all options before the defconfig argument" >&2
> +				exit 1
> +			fi
> +		done
> +	fi
>  	for i in "${configs[@]}"; do
>  		config=$i
>  		if [[ $i =~ ^.*/([^/]+)/([^@]*@|)([^.]+).yaml$ ]]; then
> -- 
> 2.47.3
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |