All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: gao xu <gaoxu2@honor.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	 Minchan Kim <minchan@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	 "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	"surenb@google.com" <surenb@google.com>,
	 zhouxiaolong <zhouxiaolong9@honor.com>
Subject: Re: zram: Optimize LZ4 dictionary compression performance
Date: Tue, 10 Mar 2026 14:39:39 +0900	[thread overview]
Message-ID: <aa-ucbuYGj-sZylm@google.com> (raw)
In-Reply-To: <ae51966c3cb445e9983230243bb6a5b2@honor.com>

On (26/03/10 02:54), gao xu wrote:
[..]
> @@ -78,10 +121,16 @@ static int lz4_compress(struct zcomp_params *params, struct zcomp_ctx *ctx,
>  					req->dst_len, params->level,
>  					zctx->mem);
>  	} else {
> +		/* rebuild base_cstream when the dictionary changes */

How often does it change and under what circumstances?

> +		if (!drv->base_c_valid || drv->dict_gen != params->dict_gen) {
> +			ret = lz4_build_base_cstream(params);
> +			if (ret)
> +				return ret;
> +		}

  reply	other threads:[~2026-03-10  5:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  2:54 zram: Optimize LZ4 dictionary compression performance gao xu
2026-03-10  5:39 ` Sergey Senozhatsky [this message]
2026-03-10  6:13 ` Sergey Senozhatsky
2026-03-10  6:22   ` Sergey Senozhatsky
2026-03-10  8:32   ` gao xu
2026-03-11  1:22     ` Sergey Senozhatsky
2026-03-11  2:55       ` gao xu
2026-03-10  6:15 ` Sergey Senozhatsky
2026-03-11  4:00   ` gao xu
2026-03-11  5:22     ` Sergey Senozhatsky
2026-03-11  1:25 ` Sergey Senozhatsky
2026-03-11  2:56   ` gao xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa-ucbuYGj-sZylm@google.com \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=gaoxu2@honor.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=surenb@google.com \
    --cc=zhouxiaolong9@honor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.