All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangyu Hua <hbh25y@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
	jreuter@yaina.de, ralf@linux-mips.org, davem@davemloft.net,
	kuba@kernel.org
Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ax25: use after free in ax25_connect
Date: Mon, 17 Jan 2022 09:35:10 +0800	[thread overview]
Message-ID: <aa1abfd4-e76b-f708-e2de-8018298ff07b@gmail.com> (raw)
In-Reply-To: <8fc4701f-c151-0545-c047-a5df90575d69@gmail.com>

I get it.

Thanks.

On 2022/1/14 下午11:19, Eric Dumazet wrote:
> 
> On 1/13/22 22:54, Hangyu Hua wrote:
>> Any suggestions for this patch ? Guys.
>>
>> I think putting sk_to_ax25 after lock_sock(sk) here will avoid any 
>> possilbe race conditions like other functions in ax25_proto_ops. CTING) {
>>
> 
> As explained, your patch is not needed.
> 
> You failed to describe how a race was possible.
> 
> Just moving code around wont help.
> 
> How about providing a stack trace or some syzbot repro ?
> 

      reply	other threads:[~2022-01-17  1:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11  4:20 [PATCH net] ax25: use after free in ax25_connect Hangyu Hua
2022-01-11 20:56 ` Eric Dumazet
2022-01-12  2:13   ` Hangyu Hua
2022-01-12  9:59     ` Eric Dumazet
2022-01-12 11:11       ` Hangyu Hua
2022-01-14  6:54         ` Hangyu Hua
2022-01-14 15:19           ` Eric Dumazet
2022-01-17  1:35             ` Hangyu Hua [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa1abfd4-e76b-f708-e2de-8018298ff07b@gmail.com \
    --to=hbh25y@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jreuter@yaina.de \
    --cc=kuba@kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.