From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
stable@vger.kernel.org, kernel-team@android.com,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: Fix definition of PAGE_HYP_DEVICE
Date: Wed, 08 Jul 2020 17:59:29 +0100 [thread overview]
Message-ID: <aa1d1bc3bbef499a909ca6367d1bc77b@kernel.org> (raw)
In-Reply-To: <20200708162546.26176-1-will@kernel.org>
On 2020-07-08 17:25, Will Deacon wrote:
> PAGE_HYP_DEVICE is intended to encode attribute bits for an EL2 stage-1
> pte mapping a device. Unfortunately, it includes PROT_DEVICE_nGnRE
> which
> encodes attributes for EL1 stage-1 mappings such as UXN and nG, which
> are
> RES0 for EL2, and DBM which is meaningless as TCR_EL2.HD is not set.
>
> Fix the definition of PAGE_HYP_DEVICE so that it doesn't set RES0 bits
> at EL2.
>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
> Marc -- I'm happy to take this as a fix via arm64 with your Ack.
> Please just let me know.
>
> arch/arm64/include/asm/pgtable-prot.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Marc Zyngier <maz@kernel.org>
Thanks for fixing this!
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
stable@vger.kernel.org, James Morse <james.morse@arm.com>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: Fix definition of PAGE_HYP_DEVICE
Date: Wed, 08 Jul 2020 17:59:29 +0100 [thread overview]
Message-ID: <aa1d1bc3bbef499a909ca6367d1bc77b@kernel.org> (raw)
In-Reply-To: <20200708162546.26176-1-will@kernel.org>
On 2020-07-08 17:25, Will Deacon wrote:
> PAGE_HYP_DEVICE is intended to encode attribute bits for an EL2 stage-1
> pte mapping a device. Unfortunately, it includes PROT_DEVICE_nGnRE
> which
> encodes attributes for EL1 stage-1 mappings such as UXN and nG, which
> are
> RES0 for EL2, and DBM which is meaningless as TCR_EL2.HD is not set.
>
> Fix the definition of PAGE_HYP_DEVICE so that it doesn't set RES0 bits
> at EL2.
>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
> Marc -- I'm happy to take this as a fix via arm64 with your Ack.
> Please just let me know.
>
> arch/arm64/include/asm/pgtable-prot.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Marc Zyngier <maz@kernel.org>
Thanks for fixing this!
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kernel-team@android.com,
Catalin Marinas <catalin.marinas@arm.com>,
James Morse <james.morse@arm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: Fix definition of PAGE_HYP_DEVICE
Date: Wed, 08 Jul 2020 17:59:29 +0100 [thread overview]
Message-ID: <aa1d1bc3bbef499a909ca6367d1bc77b@kernel.org> (raw)
In-Reply-To: <20200708162546.26176-1-will@kernel.org>
On 2020-07-08 17:25, Will Deacon wrote:
> PAGE_HYP_DEVICE is intended to encode attribute bits for an EL2 stage-1
> pte mapping a device. Unfortunately, it includes PROT_DEVICE_nGnRE
> which
> encodes attributes for EL1 stage-1 mappings such as UXN and nG, which
> are
> RES0 for EL2, and DBM which is meaningless as TCR_EL2.HD is not set.
>
> Fix the definition of PAGE_HYP_DEVICE so that it doesn't set RES0 bits
> at EL2.
>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: James Morse <james.morse@arm.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
> Marc -- I'm happy to take this as a fix via arm64 with your Ack.
> Please just let me know.
>
> arch/arm64/include/asm/pgtable-prot.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Marc Zyngier <maz@kernel.org>
Thanks for fixing this!
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-07-08 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 16:25 [PATCH] KVM: arm64: Fix definition of PAGE_HYP_DEVICE Will Deacon
2020-07-08 16:25 ` Will Deacon
2020-07-08 16:25 ` Will Deacon
2020-07-08 16:59 ` Marc Zyngier [this message]
2020-07-08 16:59 ` Marc Zyngier
2020-07-08 16:59 ` Marc Zyngier
2020-07-08 22:02 ` Will Deacon
2020-07-08 22:02 ` Will Deacon
2020-07-08 22:02 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa1d1bc3bbef499a909ca6367d1bc77b@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.