From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Subject: Re: [PATCH v3 01/57] ram: rk3399: Add ddrtype enc macro Date: Tue, 16 Jul 2019 20:57:41 +0800 Message-ID: References: <20190716115745.12585-1-jagan@amarulasolutions.com> <20190716115745.12585-2-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190716115745.12585-2-jagan@amarulasolutions.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Jagan Teki , Simon Glass , Philipp Tomsich , YouMin Chen , u-boot@lists.denx.de Cc: linux-rockchip@lists.infradead.org, gajjar04akash@gmail.com, linux-amarula@amarulasolutions.com, Manivannan Sadhasivam List-Id: linux-rockchip.vger.kernel.org Ck9uIDIwMTkvNy8xNiDkuIvljYg3OjU2LCBKYWdhbiBUZWtpIHdyb3RlOgo+IEFkZCBzaW1wbGlm aWVkIGFuZCBtZWFuaW5nZnVsIG1hY3JvIGZvciBkZHJ0eXBlIG1hY3JvLgo+Cj4gU2lnbmVkLW9m Zi1ieTogSmFnYW4gVGVraSA8amFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogWW91TWluIENoZW4gPGN5bUByb2NrLWNoaXBzLmNvbT4KClJldmlld2VkLWJ5OiBLZXZl ciBZYW5nIDxLZXZlci55YW5nQHJvY2stY2hpcHMuY29tPgoKVGhhbmtzLAogwqAtIEtldmVyCj4g LS0tCj4gICBhcmNoL2FybS9pbmNsdWRlL2FzbS9hcmNoLXJvY2tjaGlwL3NkcmFtX2NvbW1vbi5o IHwgMSArCj4gICBkcml2ZXJzL3JhbS9yb2NrY2hpcC9zZHJhbV9yazMzOTkuYyAgICAgICAgICAg ICAgIHwgMiArLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKPgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9pbmNsdWRlL2FzbS9hcmNoLXJvY2tjaGlw L3NkcmFtX2NvbW1vbi5oIGIvYXJjaC9hcm0vaW5jbHVkZS9hc20vYXJjaC1yb2NrY2hpcC9zZHJh bV9jb21tb24uaAo+IGluZGV4IGI3NTQ5ZjVkOGEuLjkyYTRjNDg1YzIgMTAwNjQ0Cj4gLS0tIGEv YXJjaC9hcm0vaW5jbHVkZS9hc20vYXJjaC1yb2NrY2hpcC9zZHJhbV9jb21tb24uaAo+ICsrKyBi L2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FyY2gtcm9ja2NoaXAvc2RyYW1fY29tbW9uLmgKPiBAQCAt NzIsNiArNzIsNyBAQCBzdHJ1Y3Qgc2RyYW1fYmFzZV9wYXJhbXMgewo+ICAgI2RlZmluZSBTWVNf UkVHX1JPV18zXzRfU0hJRlQoY2gpCSgzMCArIChjaCkpCj4gICAjZGVmaW5lIFNZU19SRUdfUk9X XzNfNF9NQVNLCQkxCj4gICAjZGVmaW5lIFNZU19SRUdfQ0hJTkZPX1NISUZUKGNoKQkoMjggKyAo Y2gpKQo+ICsjZGVmaW5lIFNZU19SRUdfRU5DX0REUlRZUEUobikJCSgobikgPDwgU1lTX1JFR19E RFJUWVBFX1NISUZUKQo+ICAgI2RlZmluZSBTWVNfUkVHX1JBTktfU0hJRlQoY2gpCQkoMTEgKyAo Y2gpICogMTYpCj4gICAjZGVmaW5lIFNZU19SRUdfUkFOS19NQVNLCQkxCj4gICAjZGVmaW5lIFNZ U19SRUdfQ09MX1NISUZUKGNoKQkJKDkgKyAoY2gpICogMTYpCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvcmFtL3JvY2tjaGlwL3NkcmFtX3JrMzM5OS5jIGIvZHJpdmVycy9yYW0vcm9ja2NoaXAvc2Ry YW1fcmszMzk5LmMKPiBpbmRleCA5YTYwYzI0MTM1Li5mNTg4MzZjMDM3IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvcmFtL3JvY2tjaGlwL3NkcmFtX3JrMzM5OS5jCj4gKysrIGIvZHJpdmVycy9yYW0v cm9ja2NoaXAvc2RyYW1fcmszMzk5LmMKPiBAQCAtMTA3Niw3ICsxMDc2LDcgQEAgc3RhdGljIHZv aWQgZHJhbV9hbGxfY29uZmlnKHN0cnVjdCBkcmFtX2luZm8gKmRyYW0sCj4gICAJdTMyIHN5c19y ZWcgPSAwOwo+ICAgCXVuc2lnbmVkIGludCBjaGFubmVsLCBpZHg7Cj4gICAKPiAtCXN5c19yZWcg fD0gcGFyYW1zLT5iYXNlLmRyYW10eXBlIDw8IFNZU19SRUdfRERSVFlQRV9TSElGVDsKPiArCXN5 c19yZWcgfD0gU1lTX1JFR19FTkNfRERSVFlQRShwYXJhbXMtPmJhc2UuZHJhbXR5cGUpOwo+ICAg CXN5c19yZWcgfD0gKHBhcmFtcy0+YmFzZS5udW1fY2hhbm5lbHMgLSAxKSA8PCBTWVNfUkVHX05V TV9DSF9TSElGVDsKPiAgIAo+ICAgCWZvciAoY2hhbm5lbCA9IDAsIGlkeCA9IDA7CgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVS1Cb290IG1haWxpbmcg bGlzdApVLUJvb3RAbGlzdHMuZGVueC5kZQpodHRwczovL2xpc3RzLmRlbnguZGUvbGlzdGluZm8v dS1ib290Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Tue, 16 Jul 2019 20:57:41 +0800 Subject: [U-Boot] [PATCH v3 01/57] ram: rk3399: Add ddrtype enc macro In-Reply-To: <20190716115745.12585-2-jagan@amarulasolutions.com> References: <20190716115745.12585-1-jagan@amarulasolutions.com> <20190716115745.12585-2-jagan@amarulasolutions.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On 2019/7/16 下午7:56, Jagan Teki wrote: > Add simplified and meaningful macro for ddrtype macro. > > Signed-off-by: Jagan Teki > Signed-off-by: YouMin Chen Reviewed-by: Kever Yang Thanks,  - Kever > --- > arch/arm/include/asm/arch-rockchip/sdram_common.h | 1 + > drivers/ram/rockchip/sdram_rk3399.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/arch-rockchip/sdram_common.h b/arch/arm/include/asm/arch-rockchip/sdram_common.h > index b7549f5d8a..92a4c485c2 100644 > --- a/arch/arm/include/asm/arch-rockchip/sdram_common.h > +++ b/arch/arm/include/asm/arch-rockchip/sdram_common.h > @@ -72,6 +72,7 @@ struct sdram_base_params { > #define SYS_REG_ROW_3_4_SHIFT(ch) (30 + (ch)) > #define SYS_REG_ROW_3_4_MASK 1 > #define SYS_REG_CHINFO_SHIFT(ch) (28 + (ch)) > +#define SYS_REG_ENC_DDRTYPE(n) ((n) << SYS_REG_DDRTYPE_SHIFT) > #define SYS_REG_RANK_SHIFT(ch) (11 + (ch) * 16) > #define SYS_REG_RANK_MASK 1 > #define SYS_REG_COL_SHIFT(ch) (9 + (ch) * 16) > diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c > index 9a60c24135..f58836c037 100644 > --- a/drivers/ram/rockchip/sdram_rk3399.c > +++ b/drivers/ram/rockchip/sdram_rk3399.c > @@ -1076,7 +1076,7 @@ static void dram_all_config(struct dram_info *dram, > u32 sys_reg = 0; > unsigned int channel, idx; > > - sys_reg |= params->base.dramtype << SYS_REG_DDRTYPE_SHIFT; > + sys_reg |= SYS_REG_ENC_DDRTYPE(params->base.dramtype); > sys_reg |= (params->base.num_channels - 1) << SYS_REG_NUM_CH_SHIFT; > > for (channel = 0, idx = 0;