Re: [PATCH] include: sbi: Change SBI spec version to 3.0

From: Atish Patra <atish.patra@linux.dev>
To: Anup Patel <apatel@ventanamicro.com>
Cc: Andrew Jones <ajones@ventanamicro.com>,
	Anup Patel <anup@brainfault.org>,
	opensbi@lists.infradead.org
Subject: Re: [PATCH] include: sbi: Change SBI spec version to 3.0
Date: Fri, 16 May 2025 11:06:12 -0700	[thread overview]
Message-ID: <aa20489e-485b-4769-aeeb-81e5783e7c5d@linux.dev> (raw)
In-Reply-To: <20250516122844.113423-1-apatel@ventanamicro.com>

On 5/16/25 5:28 AM, Anup Patel wrote:
> Now that SBI v3.0 specification is frozen, change runtime SBI version
> implemented by OpenSBI to v3.0. Also, mark extensions defined by the
> SBI v3.0 specification as non-experimental.
> 
> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> ---
>   include/sbi/sbi_ecall.h  | 2 +-
>   lib/sbi/sbi_ecall_dbtr.c | 1 -
>   lib/sbi/sbi_ecall_fwft.c | 1 -
>   lib/sbi/sbi_ecall_mpxy.c | 1 -
>   lib/sbi/sbi_ecall_sse.c  | 1 -
>   5 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/include/sbi/sbi_ecall.h b/include/sbi/sbi_ecall.h
> index 88a69bb3..15400e5a 100644
> --- a/include/sbi/sbi_ecall.h
> +++ b/include/sbi/sbi_ecall.h
> @@ -13,7 +13,7 @@
>   #include <sbi/sbi_types.h>
>   #include <sbi/sbi_list.h>
>   
> -#define SBI_ECALL_VERSION_MAJOR		2
> +#define SBI_ECALL_VERSION_MAJOR		3
>   #define SBI_ECALL_VERSION_MINOR		0
>   #define SBI_OPENSBI_IMPID		1
>   
> diff --git a/lib/sbi/sbi_ecall_dbtr.c b/lib/sbi/sbi_ecall_dbtr.c
> index d28fd396..9c496c42 100644
> --- a/lib/sbi/sbi_ecall_dbtr.c
> +++ b/lib/sbi/sbi_ecall_dbtr.c
> @@ -69,7 +69,6 @@ struct sbi_ecall_extension ecall_dbtr = {
>   	.name			= "dbtr",
>   	.extid_start		= SBI_EXT_DBTR,
>   	.extid_end		= SBI_EXT_DBTR,
> -	.experimental		= true,
>   	.handle			= sbi_ecall_dbtr_handler,
>   	.register_extensions	= sbi_ecall_dbtr_register_extensions,
>   };
> diff --git a/lib/sbi/sbi_ecall_fwft.c b/lib/sbi/sbi_ecall_fwft.c
> index 3519285e..2277405e 100644
> --- a/lib/sbi/sbi_ecall_fwft.c
> +++ b/lib/sbi/sbi_ecall_fwft.c
> @@ -45,7 +45,6 @@ struct sbi_ecall_extension ecall_fwft = {
>   	.name			= "fwft",
>   	.extid_start		= SBI_EXT_FWFT,
>   	.extid_end		= SBI_EXT_FWFT,
> -	.experimental		= true,
>   	.register_extensions	= sbi_ecall_fwft_register_extensions,
>   	.handle			= sbi_ecall_fwft_handler,
>   };
> diff --git a/lib/sbi/sbi_ecall_mpxy.c b/lib/sbi/sbi_ecall_mpxy.c
> index 03ac71b2..0a5e3525 100644
> --- a/lib/sbi/sbi_ecall_mpxy.c
> +++ b/lib/sbi/sbi_ecall_mpxy.c
> @@ -67,7 +67,6 @@ struct sbi_ecall_extension ecall_mpxy = {
>   	.name			= "mpxy",
>   	.extid_start		= SBI_EXT_MPXY,
>   	.extid_end		= SBI_EXT_MPXY,
> -	.experimental		= true,
>   	.register_extensions	= sbi_ecall_mpxy_register_extensions,
>   	.handle			= sbi_ecall_mpxy_handler,
>   };
> diff --git a/lib/sbi/sbi_ecall_sse.c b/lib/sbi/sbi_ecall_sse.c
> index 303c0f2d..b7dbf072 100644
> --- a/lib/sbi/sbi_ecall_sse.c
> +++ b/lib/sbi/sbi_ecall_sse.c
> @@ -59,7 +59,6 @@ struct sbi_ecall_extension ecall_sse = {
>   	.name			= "sse",
>   	.extid_start		= SBI_EXT_SSE,
>   	.extid_end		= SBI_EXT_SSE,
> -	.experimental		= true,
>   	.register_extensions	= sbi_ecall_sse_register_extensions,
>   	.handle			= sbi_ecall_sse_handler,
>   };

LGTM.
Reviewed-by: Atish Patra <atishp@rivosinc.com>

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi