From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74026C4708D for ; Thu, 1 Dec 2022 09:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbiLAJCK (ORCPT ); Thu, 1 Dec 2022 04:02:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbiLAJCI (ORCPT ); Thu, 1 Dec 2022 04:02:08 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFF1E47336; Thu, 1 Dec 2022 01:02:05 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 6D70224E255; Thu, 1 Dec 2022 17:01:58 +0800 (CST) Received: from EXMBX064.cuchost.com (172.16.6.64) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 17:01:58 +0800 Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX064.cuchost.com (172.16.6.64) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 17:01:57 +0800 Received: from EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e]) by EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e%16]) with mapi id 15.00.1497.044; Thu, 1 Dec 2022 17:01:58 +0800 From: JiaJie Ho To: Krzysztof Kozlowski , Herbert Xu , "David S . Miller" , "Rob Herring" , Krzysztof Kozlowski CC: "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: RE: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Thread-Topic: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Thread-Index: AQHZBH/2P5dLP9b8iUC7OZp9LCFzsa5W7gcAgAHFddA= Date: Thu, 1 Dec 2022 09:01:58 +0000 Message-ID: References: <20221130055214.2416888-1-jiajie.ho@starfivetech.com> <20221130055214.2416888-6-jiajie.ho@starfivetech.com> <8a8f502e-e0ed-d638-0b56-74edcbca2134@linaro.org> In-Reply-To: <8a8f502e-e0ed-d638-0b56-74edcbca2134@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogS3J6eXN6dG9mIEtvemxv d3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPg0KPiBTZW50OiBXZWRuZXNkYXks IE5vdmVtYmVyIDMwLCAyMDIyIDk6MjEgUE0NCj4gVG86IEppYUppZSBIbyA8amlhamllLmhvQHN0 YXJmaXZldGVjaC5jb20+OyBIZXJiZXJ0IFh1DQo+IDxoZXJiZXJ0QGdvbmRvci5hcGFuYS5vcmcu YXU+OyBEYXZpZCBTIC4gTWlsbGVyIDxkYXZlbUBkYXZlbWxvZnQubmV0PjsNCj4gUm9iIEhlcnJp bmcgPHJvYmgrZHRAa2VybmVsLm9yZz47IEtyenlzenRvZiBLb3psb3dza2kNCj4gPGtyenlzenRv Zi5rb3psb3dza2krZHRAbGluYXJvLm9yZz4NCj4gQ2M6IGxpbnV4LWNyeXB0b0B2Z2VyLmtlcm5l bC5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eC0NCj4ga2VybmVsQHZnZXIu a2VybmVsLm9yZzsgbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZw0KPiBTdWJqZWN0OiBS ZTogW1BBVENIIDUvNl0gZHQtYmluZGluZ3M6IGNyeXB0bzogQWRkIGJpbmRpbmdzIGZvciBTdGFy Zml2ZSBjcnlwdG8NCj4gZHJpdmVyDQo+IA0KPiBPbiAzMC8xMS8yMDIyIDA2OjUyLCBKaWEgSmll IEhvIHdyb3RlOg0KPiA+IEFkZCBkb2N1bWVudGF0aW9uIHRvIGRlc2NyaWJlIFN0YXJmaXZlIGNy eXB0byBkcml2ZXIgYmluZGluZ3MuDQo+IA0KPiBQbGVhc2Ugd3JhcCBjb21taXQgbWVzc2FnZSBh Y2NvcmRpbmcgdG8gTGludXggY29kaW5nIHN0eWxlIC8gc3VibWlzc2lvbg0KPiBwcm9jZXNzOg0K PiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC92NS4xOC0NCj4gcmM0L3NvdXJjZS9E b2N1bWVudGF0aW9uL3Byb2Nlc3Mvc3VibWl0dGluZy1wYXRjaGVzLnJzdCNMNTg2DQo+IA0KPiAN Cj4gU3ViamVjdDogZHJvcCBzZWNvbmQsIHJlZHVuZGFudCAiYmluZGluZ3MiLg0KPiANCj4gDQoN CkknbGwgZml4IHRoZSBjb21taXQgdGl0bGUgYW5kIG1lc3NhZ2UgaW4gdGhlIG5leHQgdmVyc2lv bi4NCg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogSmlhIEppZSBIbyA8amlhamllLmhvQHN0YXJm aXZldGVjaC5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogSHVhbiBGZW5nIDxodWFuLmZlbmdAc3Rh cmZpdmV0ZWNoLmNvbT4NCj4gPiAtLS0NCj4gPiAgLi4uL2JpbmRpbmdzL2NyeXB0by9zdGFyZml2 ZS1jcnlwdG8ueWFtbCAgICAgIHwgMTA5ICsrKysrKysrKysrKysrKysrKw0KPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMTA5IGluc2VydGlvbnMoKykNCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0DQo+ID4g RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2NyeXB0by9zdGFyZml2ZS1jcnlwdG8u eWFtbA0KPiA+DQo+ID4gZGlmZiAtLWdpdA0KPiA+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2NyeXB0by9zdGFyZml2ZS1jcnlwdG8ueWFtbA0KPiA+IGIvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2NyeXB0by9zdGFyZml2ZS1jcnlwdG8ueWFtbA0KPiA+IG5l dyBmaWxlIG1vZGUgMTAwNjQ0DQo+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi42Yjg1MmY3NzRjMzIN Cj4gPiAtLS0gL2Rldi9udWxsDQo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2NyeXB0by9zdGFyZml2ZS1jcnlwdG8ueWFtbA0KPiANCj4gRmlsZW5hbWUgYmFzZWQg b24gY29tcGF0aWJsZSwgc28gc3RhcmZpdmUsamg3MTEwLWNyeXB0by55YW1sDQo+IA0KDQpXaWxs IHVwZGF0ZSBmaWxlbmFtZS4NCg0KPiA+IEBAIC0wLDAgKzEsMTA5IEBADQo+ID4gKyMgU1BEWC1M aWNlbnNlLUlkZW50aWZpZXI6IChHUEwtMi4wLW9ubHkgT1IgQlNELTItQ2xhdXNlKSAlWUFNTCAx LjINCj4gPiArLS0tDQo+ID4gKyRpZDogaHR0cDovL2RldmljZXRyZWUub3JnL3NjaGVtYXMvY3J5 cHRvL3N0YXJmaXZlLWNyeXB0by55YW1sIw0KPiA+ICskc2NoZW1hOiBodHRwOi8vZGV2aWNldHJl ZS5vcmcvbWV0YS1zY2hlbWFzL2NvcmUueWFtbCMNCj4gPiArDQo+ID4gK3RpdGxlOiBTdGFyRml2 ZSBDcnlwdG8gQ29udHJvbGxlciBEZXZpY2UgVHJlZSBCaW5kaW5ncw0KPiANCj4gRHJvcCAiRGV2 aWNlIFRyZWUgQmluZGluZ3MiDQo+IA0KDQpXaWxsIHVwZGF0ZSB0aXRsZS4NCg0KPiA+ICsNCj4g PiArbWFpbnRhaW5lcnM6DQo+ID4gKyAgLSBKaWEgSmllIEhvIDxqaWFqaWUuaG9Ac3RhcmZpdmV0 ZWNoLmNvbT4NCj4gPiArICAtIFdpbGxpYW0gUWl1IDx3aWxsaWFtLnFpdUBzdGFyZml2ZXRlY2gu Y29tPg0KPiA+ICsNCj4gPiArcHJvcGVydGllczoNCj4gPiArICBjb21wYXRpYmxlOg0KPiA+ICsg ICAgY29uc3Q6IHN0YXJmaXZlLGpoNzExMC1jcnlwdG8NCj4gPiArDQo+ID4gKyAgcmVnOg0KPiA+ ICsgICAgbWF4SXRlbXM6IDENCj4gPiArDQo+ID4gKyAgcmVnLW5hbWVzOg0KPiA+ICsgICAgaXRl bXM6DQo+ID4gKyAgICAgIC0gY29uc3Q6IHNlY3JlZw0KPiANCj4gV2h5IGRvIHlvdSBuZWVkIHJl Zy1uYW1lcyBmb3Igb25lIGVudHJ5Pw0KPiANCg0KV2lsbCByZW1vdmUgbmVlZCBvZiByZWctbmFt ZXMgYW5kIHVwZGF0ZSBwcm9iZSBmdW5jdGlvbiBhY2NvcmRpbmdseS4NCg0KPiA+ICsNCj4gPiAr ICBjbG9ja3M6DQo+ID4gKyAgICBpdGVtczoNCj4gPiArICAgICAgLSBkZXNjcmlwdGlvbjogSGFy ZHdhcmUgcmVmZXJlbmNlIGNsb2NrDQo+ID4gKyAgICAgIC0gZGVzY3JpcHRpb246IEFIQiByZWZl cmVuY2UgY2xvY2sNCj4gPiArDQo+ID4gKyAgY2xvY2stbmFtZXM6DQo+ID4gKyAgICBpdGVtczoN Cj4gPiArICAgICAgLSBjb25zdDogc2VjX2hjbGsNCj4gPiArICAgICAgLSBjb25zdDogc2VjX2Fo Yg0KPiANCj4gc2VjIHNlZW1zIHJlZHVuZGFudCwgc28ganVzdCAiYWhiIi4gVGhlIGZpcnN0IGNs b2NrIHRoZW4gImhjbGsiIG9yICJyZWYiPw0KPiANCg0KV2lsbCBmaXggaW4gbmV4dCB2ZXJzaW9u Lg0KDQo+ID4gKw0KPiA+ICsgIGludGVycnVwdHM6DQo+ID4gKyAgICBpdGVtczoNCj4gPiArICAg ICAgLSBkZXNjcmlwdGlvbjogSW50ZXJydXB0IHBpbiBmb3IgYWxnbyBjb21wbGV0aW9uDQo+ID4g KyAgICAgIC0gZGVzY3JpcHRpb246IEludGVycnVwdCBwaW4gZm9yIERNQSB0cmFuc2ZlciBjb21w bGV0aW9uDQo+ID4gKw0KPiA+ICsgIGludGVycnVwdC1uYW1lczoNCj4gPiArICAgIGl0ZW1zOg0K PiA+ICsgICAgICAtIGNvbnN0OiBzZWNpcnENCj4gPiArICAgICAgLSBjb25zdDogZG1haXJxDQo+ IA0KPiBEcm9wICJpcnEiIGZyb20gYm90aC4NCj4gDQoNCldpbGwgZml4Lg0KDQo+ID4gKw0KPiA+ ICsgIHJlc2V0czoNCj4gPiArICAgIGl0ZW1zOg0KPiA+ICsgICAgICAtIGRlc2NyaXB0aW9uOiBT VEcgZG9tYWluIHJlc2V0IGxpbmUNCj4gPiArDQo+ID4gKyAgcmVzZXQtbmFtZXM6DQo+ID4gKyAg ICBpdGVtczoNCj4gPiArICAgICAgLSBjb25zdDogc2VjX2hyZQ0KPiANCj4gRHJvcCAic2VjIi4g V2h5IGRvIHlvdSBuZWVkIHRoZSBuYW1lcyBmb3Igb25lIGVudHJ5Pw0KPiANCg0KV2lsbCByZW1v dmUgbmFtZXMuDQoNCj4gPiArDQo+ID4gKyAgZW5hYmxlLXNpZGUtY2hhbm5lbC1taXRpZ2F0aW9u Og0KPiA+ICsgICAgZGVzY3JpcHRpb246IEVuYWJsZSBzaWRlLWNoYW5uZWwtbWl0aWdhdGlvbiBm ZWF0dXJlIGZvciBBRVMgbW9kdWxlLg0KPiA+ICsgICAgICAgIEVuYWJsaW5nIHRoaXMgZmVhdHVy ZSB3aWxsIGFmZmVjdCB0aGUgc3BlZWQgcGVyZm9ybWFuY2Ugb2YNCj4gPiArICAgICAgICBjcnlw dG8gZW5naW5lLg0KPiA+ICsgICAgdHlwZTogYm9vbGVhbg0KPiANCj4gV2h5IGV4YWN0bHkgdGhp cyBpcyBhIGhhcmR3YXJlIChEVCkgcHJvcGVydHksIG5vdCBydW50aW1lPw0KPiANCg0KVGhpcyBp cyBhIGhhcmR3YXJlIHNldHRpbmcgcHJvdmlkZWQgaW4gU3RhckZpdmUgY3J5cHRvIGVuZ2luZSBv bmx5Lg0KVGhlIGNyeXB0byBBUEkgZG9lc24ndCBjb250cm9sIHRoaXMgc2V0dGluZyBkdXJpbmcg cnVudGltZSBhbmQgbGVhdmluZyB0aGlzIGFsd2F5cyBvbiB3aWxsIGltcGFjdCBzcGVlZCBwZXJm b3JtYW5jZS4NClNvLCBJIGFkZGVkIHRoaXMgcHJvcGVydHkgdG8gYWxsb3cgdXNlciB0byBjb250 cm9sIHRoaXMgaW4gZHRiLg0KDQo+ID4gKw0KPiA+ICsgIGVuYWJsZS1kbWE6DQo+ID4gKyAgICBk ZXNjcmlwdGlvbjogRW5hYmxlIGRhdGEgdHJhbnNmZXIgdXNpbmcgZGVkaWNhdGVkIERNQSBjb250 cm9sbGVyLg0KPiA+ICsgICAgdHlwZTogYm9vbGVhbg0KPiANCj4gVXN1YWxseSB0aGUgcHJlc2Vu Y2Ugb2YgZG1hcyBpbmRpY2F0ZXMgd2hldGhlciB0byB1c2Ugb3Igbm90IHRvIHVzZSBETUEuDQo+ IERvIHlvdSBleHBlY3QgYSBjYXNlIHdoZXJlIERNQSBjaGFubmVscyBhcmUgcHJvdmlkZWQgYnkg eW91IGRvbid0IHdhbnQNCj4gRE1BPyBFeHBsYWluIHN1Y2ggY2FzZSBhbmQgZGVzY3JpYmUgd2h5 IGl0IGlzIGEgaGFyZHdhcmUvc3lzdGVtIGludGVncmF0aW9uDQo+IHByb3BlcnR5Lg0KPiANCg0K SSdsbCByZW1vdmUgdGhpcyBwcm9wZXJ0eSBhcyBETUEgaXMgYWx3YXlzIGVuYWJsZWQuDQoNCj4g PiArDQo+ID4gKyAgZG1hczoNCj4gPiArICAgIGl0ZW1zOg0KPiA+ICsgICAgICAtIGRlc2NyaXB0 aW9uOiBUWCBETUEgY2hhbm5lbA0KPiA+ICsgICAgICAtIGRlc2NyaXB0aW9uOiBSWCBETUEgY2hh bm5lbA0KPiA+ICsNCj4gPiArICBkbWEtbmFtZXM6DQo+ID4gKyAgICBpdGVtczoNCj4gPiArICAg ICAgLSBjb25zdDogc2VjX20NCj4gDQo+IHR4DQo+IA0KDQpXaWxsIGZpeC4NCg0KPiA+ICsgICAg ICAtIGNvbnN0OiBzZWNfcA0KPiANCj4gcngNCj4gDQoNCldpbGwgZml4Lg0KDQo+ID4gKw0KPiA+ ICtyZXF1aXJlZDoNCj4gPiArICAtIGNvbXBhdGlibGUNCj4gPiArICAtIHJlZw0KPiA+ICsgIC0g cmVnLW5hbWVzDQo+ID4gKyAgLSBjbG9ja3MNCj4gPiArICAtIGNsb2NrLW5hbWVzDQo+ID4gKyAg LSByZXNldHMNCj4gPiArICAtIHJlc2V0LW5hbWVzDQo+ID4gKw0KPiA+ICthZGRpdGlvbmFsUHJv cGVydGllczogZmFsc2UNCj4gPiArDQo+ID4gK2V4YW1wbGVzOg0KPiA+ICsgIC0gfA0KPiA+ICsg ICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL2Nsb2NrL3N0YXJmaXZlLWpoNzExMC5oPg0KPiA+ICsg ICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL3Jlc2V0L3N0YXJmaXZlLWpoNzExMC5oPg0KPiA+ICsN Cj4gPiArICAgIHNvYyB7DQo+ID4gKyAgICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDI+Ow0K PiA+ICsgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwyPjsNCj4gDQo+IFVzZSA0IHNwYWNlcyBm b3IgZXhhbXBsZSBpbmRlbnRhdGlvbi4NCg0KSSdsbCBmaXggdGhlIGluZGVudGF0aW9uLg0KDQpU aGFuayB5b3UgZm9yIHRha2luZyB0aW1lIHRvIHJldmlldyBhbmQgcHJvdmlkZSBoZWxwZnVsIGNv bW1lbnRzIGZvciB0aGlzIHBhdGNoLg0KDQpCZXN0IHJlZ2FyZHMsDQpKaWEgSmllDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64316C43217 for ; Thu, 1 Dec 2022 09:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JIGxpKZOSkbLR9D9i+dZK/YcZkhWDW5RSEG1NmIyZbY=; b=QvD5GRjRDwjt6i 4E/kQ2yTczWOxIwb93fDvMalS0zSXhEUKXU0CRLJgivKh/HcjSLZLi1u1OqfyirKynaodFQRs+/YE 7trNQSC9Q2TpFbgm8pyGmdJDnzY9X96Rt7pUMv5eju+kpCNz1/1IRENVuoiMlYEXw+H2fLGUAdkJ3 wqEDNXyfxsk8U/Ip0lNjKoAmKylnO5N6/A8GsnHMMxNc5DyAGCj7YM3b1vWr6+1rAe8TbvFejZ1PV NvvpYGf1LKSV085MKDERh2PcMHnTy4dphF0U6H7aTpuc/u7OvMsfVdkal1xtH6hBrz7evVN71KXSY +d9r4N28M7o2UtbfPElA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0fSk-0068EM-WD; Thu, 01 Dec 2022 09:02:35 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0fSg-00684J-CS for linux-riscv@lists.infradead.org; Thu, 01 Dec 2022 09:02:33 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 6D70224E255; Thu, 1 Dec 2022 17:01:58 +0800 (CST) Received: from EXMBX064.cuchost.com (172.16.6.64) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 17:01:58 +0800 Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX064.cuchost.com (172.16.6.64) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 1 Dec 2022 17:01:57 +0800 Received: from EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e]) by EXMBX068.cuchost.com ([fe80::c4da:cbc4:bb39:ca7e%16]) with mapi id 15.00.1497.044; Thu, 1 Dec 2022 17:01:58 +0800 From: JiaJie Ho To: Krzysztof Kozlowski , Herbert Xu , "David S . Miller" , "Rob Herring" , Krzysztof Kozlowski CC: "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: RE: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Thread-Topic: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Thread-Index: AQHZBH/2P5dLP9b8iUC7OZp9LCFzsa5W7gcAgAHFddA= Date: Thu, 1 Dec 2022 09:01:58 +0000 Message-ID: References: <20221130055214.2416888-1-jiajie.ho@starfivetech.com> <20221130055214.2416888-6-jiajie.ho@starfivetech.com> <8a8f502e-e0ed-d638-0b56-74edcbca2134@linaro.org> In-Reply-To: <8a8f502e-e0ed-d638-0b56-74edcbca2134@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_010230_741694_98B1E09C X-CRM114-Status: GOOD ( 27.50 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Wednesday, November 30, 2022 9:21 PM > To: JiaJie Ho ; Herbert Xu > ; David S . Miller ; > Rob Herring ; Krzysztof Kozlowski > > Cc: linux-crypto@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-riscv@lists.infradead.org > Subject: Re: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto > driver > > On 30/11/2022 06:52, Jia Jie Ho wrote: > > Add documentation to describe Starfive crypto driver bindings. > > Please wrap commit message according to Linux coding style / submission > process: > https://elixir.bootlin.com/linux/v5.18- > rc4/source/Documentation/process/submitting-patches.rst#L586 > > > Subject: drop second, redundant "bindings". > > I'll fix the commit title and message in the next version. > > > > Signed-off-by: Jia Jie Ho > > Signed-off-by: Huan Feng > > --- > > .../bindings/crypto/starfive-crypto.yaml | 109 ++++++++++++++++++ > > 1 file changed, 109 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/crypto/starfive-crypto.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/crypto/starfive-crypto.yaml > > b/Documentation/devicetree/bindings/crypto/starfive-crypto.yaml > > new file mode 100644 > > index 000000000000..6b852f774c32 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/crypto/starfive-crypto.yaml > > Filename based on compatible, so starfive,jh7110-crypto.yaml > Will update filename. > > @@ -0,0 +1,109 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/crypto/starfive-crypto.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: StarFive Crypto Controller Device Tree Bindings > > Drop "Device Tree Bindings" > Will update title. > > + > > +maintainers: > > + - Jia Jie Ho > > + - William Qiu > > + > > +properties: > > + compatible: > > + const: starfive,jh7110-crypto > > + > > + reg: > > + maxItems: 1 > > + > > + reg-names: > > + items: > > + - const: secreg > > Why do you need reg-names for one entry? > Will remove need of reg-names and update probe function accordingly. > > + > > + clocks: > > + items: > > + - description: Hardware reference clock > > + - description: AHB reference clock > > + > > + clock-names: > > + items: > > + - const: sec_hclk > > + - const: sec_ahb > > sec seems redundant, so just "ahb". The first clock then "hclk" or "ref"? > Will fix in next version. > > + > > + interrupts: > > + items: > > + - description: Interrupt pin for algo completion > > + - description: Interrupt pin for DMA transfer completion > > + > > + interrupt-names: > > + items: > > + - const: secirq > > + - const: dmairq > > Drop "irq" from both. > Will fix. > > + > > + resets: > > + items: > > + - description: STG domain reset line > > + > > + reset-names: > > + items: > > + - const: sec_hre > > Drop "sec". Why do you need the names for one entry? > Will remove names. > > + > > + enable-side-channel-mitigation: > > + description: Enable side-channel-mitigation feature for AES module. > > + Enabling this feature will affect the speed performance of > > + crypto engine. > > + type: boolean > > Why exactly this is a hardware (DT) property, not runtime? > This is a hardware setting provided in StarFive crypto engine only. The crypto API doesn't control this setting during runtime and leaving this always on will impact speed performance. So, I added this property to allow user to control this in dtb. > > + > > + enable-dma: > > + description: Enable data transfer using dedicated DMA controller. > > + type: boolean > > Usually the presence of dmas indicates whether to use or not to use DMA. > Do you expect a case where DMA channels are provided by you don't want > DMA? Explain such case and describe why it is a hardware/system integration > property. > I'll remove this property as DMA is always enabled. > > + > > + dmas: > > + items: > > + - description: TX DMA channel > > + - description: RX DMA channel > > + > > + dma-names: > > + items: > > + - const: sec_m > > tx > Will fix. > > + - const: sec_p > > rx > Will fix. > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - clocks > > + - clock-names > > + - resets > > + - reset-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > Use 4 spaces for example indentation. I'll fix the indentation. Thank you for taking time to review and provide helpful comments for this patch. Best regards, Jia Jie _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv