All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: Muchun Song <muchun.song@linux.dev>
Cc: Muchun Song <songmuchun@bytedance.com>,
	maddy@linux.ibm.com, rppt@kernel.org, akpm@linux-foundation.org,
	david@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com,
	chleroy@kernel.org, ritesh.list@gmail.com, sshegde@linux.ibm.com,
	ljs@kernel.org, liam@infradead.org, vbabka@kernel.org,
	surenb@google.com, mhocko@suse.com, qi.zheng@linux.dev,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v3 2/6] mm/sparse-vmemmap: support device DAX in common vmemmap path
Date: Wed, 30 Sep 2026 21:38:27 +0800	[thread overview]
Message-ID: <aa39ec65-a2c2-4396-b20e-4e4e7447df26@linux.dev> (raw)
In-Reply-To: <62E3517E-517D-4C23-A04A-F5BEB0A84C60@linux.dev>



On 2026/9/30 19:11, Muchun Song wrote:
[...]
> 
> Your proposed fix looks correct to me. I would slightly prefer keeping the
> rollback close to the failure:
> 
>             err = sparse_add_section(nid, pfn, cur_nr_pages, altmap,
>                                      params->pgmap);
>             if (err) {
>                     __remove_pages(start_pfn, pfn - start_pfn, altmap,
>                                    params->pgmap);
>                     break;
>             }
> 

Cool. Will shamelessly steal this approach :D

> If the first section fails, this simply calls __remove_pages() with an
> empty range, which is a harmless no-op.
> 
> Would you mind sending this as a separate bug fix? I will ACK it.

Certainly! Lance


  reply	other threads:[~2026-09-30 13:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  5:32 [PATCH v3 0/6] mm: Unify device DAX and HugeTLB vmemmap population paths Muchun Song
2026-09-29  5:32 ` [PATCH v3 1/6] mm/sparse-vmemmap: drop VMEMMAP_POPULATE_DAX Muchun Song
2026-09-30  4:24   ` Lance Yang
2026-09-29  5:32 ` [PATCH v3 2/6] mm/sparse-vmemmap: support device DAX in common vmemmap path Muchun Song
2026-09-30  8:53   ` Lance Yang
2026-09-30 10:09     ` Muchun Song
2026-09-30 11:11     ` Muchun Song
2026-09-30 13:38       ` Lance Yang [this message]
2026-09-30 10:02   ` Lance Yang
2026-09-29  5:32 ` [PATCH v3 3/6] mm/sparse-vmemmap: drop Device DAX-specific population path Muchun Song
2026-10-01 14:27   ` Lance Yang
2026-09-29  5:32 ` [PATCH v3 4/6] mm/sparse-vmemmap: remove the unused ptpfn argument Muchun Song
2026-10-01 14:52   ` Lance Yang
2026-09-29  5:32 ` [PATCH v3 5/6] mm/sparse-vmemmap: open-code vmemmap_populate_address() Muchun Song
2026-10-01 15:10   ` Lance Yang
2026-09-29  5:32 ` [PATCH v3 6/6] mm/mm_init: add zone mismatch warning during page init Muchun Song
2026-10-01 14:42   ` Mike Rapoport
2026-10-01 16:07     ` Lance Yang
2026-10-02  1:48     ` Muchun Song
2026-10-02  8:22       ` Mike Rapoport
2026-10-02  9:56         ` Muchun Song
2026-10-02 18:12           ` Mike Rapoport
2026-10-05 16:27             ` Muchun Song
2026-10-06 10:52               ` Mike Rapoport
2026-10-06 13:32                 ` Muchun Song
2026-10-08  7:45                   ` Mike Rapoport
2026-10-08  8:16                     ` Muchun Song
2026-10-01 16:09   ` Lance Yang
2026-09-29 21:32 ` [PATCH v3 0/6] mm: Unify device DAX and HugeTLB vmemmap population paths Andrew Morton
2026-09-30  1:26   ` Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa39ec65-a2c2-4396-b20e-4e4e7447df26@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=chleroy@kernel.org \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ljs@kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=mhocko@suse.com \
    --cc=mpe@ellerman.id.au \
    --cc=muchun.song@linux.dev \
    --cc=npiggin@gmail.com \
    --cc=qi.zheng@linux.dev \
    --cc=ritesh.list@gmail.com \
    --cc=rppt@kernel.org \
    --cc=songmuchun@bytedance.com \
    --cc=sshegde@linux.ibm.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.