From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Soumyajyotii Ssarkar <soumyajyotisarkar23@gmail.com>
Cc: xen-devel@lists.xenproject.org, sarkarsoumyajyoti23@gmail.com,
"Jan Beulich" <jbeulich@suse.com>,
"Daniel P . Smith" <dpsmith@apertussolutions.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/3] x86/acpi: Remove BGRT invalidation code
Date: Sun, 8 Mar 2026 19:30:27 +0100 [thread overview]
Message-ID: <aa3AQ_LBdKLIBWpe@mail-itl> (raw)
In-Reply-To: <CAGkZZ+tjOGskPuSipkkOBjussxy5h_fDhNOMt-6Q9cqWJQi4kw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]
On Fri, Mar 06, 2026 at 08:59:07AM +0530, Soumyajyotii Ssarkar wrote:
> On Fri, Mar 6, 2026 at 7:23 AM Marek Marczykowski-Górecki <
> marmarek@invisiblethingslab.com> wrote:
>
> > On Fri, Mar 06, 2026 at 12:48:09AM +0530, Soumyajyotii Ssarkar wrote:
> > > Now that BGRT images are preserved during EFI boot (via
> > > EfiACPIReclaimMemory allocation), the invalidation code in
> > > acpi_parse_bgrt() is no longer needed. The BGRT table remains
> > > valid throughout boot.
> > >
> > > This removes the code that was marking BGRT invalid when the
> > > image memory was detected as unavailable, which was causing
> > > ACPI warnings in Linux dom0.
> >
> > When preserving failed for any reason, or when it was disabled (the next
> > patch), the entry still should be invalidated. In fact, the check here
> > for RAM_TYPE_CONVENTIONAL may already disable invalidation when it got
> > preserved?
> >
> > --
> > Best Regards,
> > Marek Marczykowski-Górecki
> > Invisible Things Lab
> >
>
>
> I could move forward with dropping the [PATCH 2/3]. And adapt the other
> patches accordingly.
> This would serve as a safety net in case the preservation fails for any
> reason. Would that be a valid approach?
Yes, exactly.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-03-08 18:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 19:18 [PATCH 0/3] Fixing ACPI BGRT (Boot Graphics Resource Table) corruption Soumyajyotii Ssarkar
2026-03-05 19:18 ` [PATCH 1/3] x86/efi: Add BGRT image preservation during boot Soumyajyotii Ssarkar
2026-03-08 18:30 ` Marek Marczykowski-Górecki
2026-03-09 7:31 ` Jan Beulich
2026-03-10 13:05 ` Soumyajyotii Ssarkar
2026-03-10 14:14 ` Jan Beulich
2026-03-14 4:32 ` Soumyajyotii Ssarkar
2026-03-05 19:18 ` [PATCH 2/3] x86/acpi: Remove BGRT invalidation code Soumyajyotii Ssarkar
2026-03-06 1:53 ` Marek Marczykowski-Górecki
2026-03-06 3:29 ` Soumyajyotii Ssarkar
2026-03-08 18:30 ` Marek Marczykowski-Górecki [this message]
2026-03-05 19:18 ` [PATCH 3/3] x86/efi: Add opt-out mechanism for BGRT preservation Soumyajyotii Ssarkar
2026-03-08 18:34 ` Marek Marczykowski-Górecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa3AQ_LBdKLIBWpe@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=andrew.cooper3@citrix.com \
--cc=dpsmith@apertussolutions.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=sarkarsoumyajyoti23@gmail.com \
--cc=soumyajyotisarkar23@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.