From: Claudiu.Beznea at microchip.com <Claudiu.Beznea@microchip.com>
To: u-boot@lists.denx.de
Subject: [PATCH 01/22] clk: check hw and hw->dev before dereference it
Date: Tue, 4 Aug 2020 15:55:38 +0000 [thread overview]
Message-ID: <aa40f463-c8a2-584a-a94d-68e71a19aaf2@microchip.com> (raw)
In-Reply-To: <CAPnjgZ1bgUxt4zq7tryCr3=fxhZCqKdBjoQudo6QUjJYOEjvDQ@mail.gmail.com>
On 04.08.2020 18:29, Simon Glass wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Claudiu,
>
> On Tue, 4 Aug 2020 at 09:25, <Claudiu.Beznea@microchip.com> wrote:
>>
>> Hi Simon,
>>
>> On 04.08.2020 18:08, Simon Glass wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> Hi Claudiu,
>>>
>>> On Tue, 4 Aug 2020 at 01:19, <Claudiu.Beznea@microchip.com> wrote:
>>>>
>>>>
>>>>
>>>> On 04.08.2020 05:00, Simon Glass wrote:
>>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>>>
>>>>> Hi Claudiu,
>>>>>
>>>>> On Wed, 29 Jul 2020 at 08:51, Claudiu Beznea
>>>>> <claudiu.beznea@microchip.com> wrote:
>>>>>>
>>>>>> Check hw and hw->dev before dereference it.
>>>>>>
>>>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>>>>>> ---
>>>>>> drivers/clk/clk.c | 3 +++
>>>>>> 1 file changed, 3 insertions(+)
>>>>>>
>>>>>
>>>>> Why is this needed? It adds to code size and these situations should
>>>>> not occur. Perhaps use assert()?
>>>>
>>>> In my debugging, investigating the issues that patches 03/22, 04/22, 06/22
>>>> try to address, I reached also this function and checked these pointers. In
>>>> the end the issue was not related to them but I though it might be useful
>>>> to keep these in a patch. I will remove it in the next version.
>>>
>>> IMO we should use assert() to check invariants and catch basic
>>> programming errors. But production testing should make sure that the
>>> software basically works.
>>>
>>> Of course it is nice to have these checks, but they add to code size
>>> which is always a concern. So I think we should rely on assert() to
>>> catch the errors during development, so we are not wasting code
>>> checking for things that we know cannot happen.
>>
>> OK, I'll switch to assert().
>
> One more point I should have made is that my comments apply mostly to
> common code that everyone has to use - e.g. the core clock code. So if
> you want to put dev_err() and other things in your driver and you know
> about the code-size implications that is less of a concern. But with
> common code, we should be careful.
Sure!
Thank you,
Claudiu Beznea
>
> Regards,
> Simon
>
next prev parent reply other threads:[~2020-08-04 15:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 14:51 [PATCH 00/22] clk: at91: add sama7g5 support Claudiu Beznea
2020-07-29 14:51 ` [PATCH 01/22] clk: check hw and hw->dev before dereference it Claudiu Beznea
2020-08-04 2:00 ` Simon Glass
2020-08-04 7:19 ` Claudiu.Beznea at microchip.com
2020-08-04 15:08 ` Simon Glass
2020-08-04 15:25 ` Claudiu.Beznea at microchip.com
2020-08-04 15:29 ` Simon Glass
2020-08-04 15:55 ` Claudiu.Beznea at microchip.com [this message]
2020-07-29 14:51 ` [PATCH 02/22] clk: check pointer returned by dev_get_parent() Claudiu Beznea
2020-08-04 2:00 ` Simon Glass
2020-08-04 7:19 ` Claudiu.Beznea at microchip.com
2020-07-29 14:51 ` [PATCH 03/22] dm: core: add support for device re-parenting Claudiu Beznea
2020-08-04 2:00 ` Simon Glass
2020-08-04 7:24 ` Claudiu.Beznea at microchip.com
2020-07-29 14:51 ` [PATCH 04/22] clk: bind clk to new parent device Claudiu Beznea
2020-08-04 2:00 ` Simon Glass
2020-08-04 7:24 ` Claudiu.Beznea at microchip.com
2020-07-29 14:51 ` [PATCH 05/22] clk: do not disable clock if it is critical Claudiu Beznea
2020-08-04 2:00 ` Simon Glass
2020-07-29 14:51 ` [PATCH 06/22] clk: get clock pointer before proceeding Claudiu Beznea
2020-08-04 2:00 ` Simon Glass
2020-08-04 7:26 ` Claudiu.Beznea at microchip.com
2020-07-29 14:51 ` [PATCH 07/22] clk: at91: add pre-requisite headers for AT91 clock architecture Claudiu Beznea
2020-07-29 14:51 ` [PATCH 08/22] clk: at91: pmc: add helpers for clock drivers Claudiu Beznea
2020-07-29 14:51 ` [PATCH 09/22] clk: at91: move clock code to compat.c Claudiu Beznea
2020-07-29 14:51 ` [PATCH 10/22] clk: at91: sckc: add driver compatible with ccf Claudiu Beznea
2020-07-29 14:51 ` [PATCH 11/22] clk: at91: clk-main: " Claudiu Beznea
2020-07-29 14:51 ` [PATCH 12/22] clk: at91: sam9x60-pll: " Claudiu Beznea
2020-07-29 14:51 ` [PATCH 13/22] clk: at91: clk-master: " Claudiu Beznea
2020-07-29 14:51 ` [PATCH 14/22] clk: at91: clk-master: add support for sama7g5 Claudiu Beznea
2020-07-29 14:51 ` [PATCH 15/22] clk: at91: clk-utmi: add driver compatible with ccf Claudiu Beznea
2020-07-29 14:51 ` [PATCH 16/22] clk: at91: clk-utmi: add support for sama7g5 Claudiu Beznea
2020-07-29 14:51 ` [PATCH 17/22] clk: at91: clk-programmable: add driver compatible with ccf Claudiu Beznea
2020-07-29 14:51 ` [PATCH 18/22] clk: at91: clk-system: " Claudiu Beznea
2020-07-29 14:51 ` [PATCH 19/22] clk: at91: clk-peripheral: " Claudiu Beznea
2020-07-29 14:51 ` [PATCH 20/22] clk: at91: clk-generic: " Claudiu Beznea
2020-07-29 14:51 ` [PATCH 21/22] clk: at91: pmc: add generic clock ops Claudiu Beznea
2020-07-29 14:51 ` [PATCH 22/22] clk: at91: sama7g5: add clock support Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa40f463-c8a2-584a-a94d-68e71a19aaf2@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.